From 5f8f83c6d87b6c7e991a31cdbef99c1bde46d464 Mon Sep 17 00:00:00 2001 From: Devin Slauenwhite Date: Fri, 29 Apr 2022 16:28:49 -0400 Subject: [PATCH] fix: warn user pick list is not complete instead of auto fulfilling picked_qty. --- erpnext/stock/doctype/pick_list/pick_list.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/erpnext/stock/doctype/pick_list/pick_list.py b/erpnext/stock/doctype/pick_list/pick_list.py index 70d2f23070..29dafbb5ca 100644 --- a/erpnext/stock/doctype/pick_list/pick_list.py +++ b/erpnext/stock/doctype/pick_list/pick_list.py @@ -42,8 +42,14 @@ class PickList(Document): update_sales_orders = set() for item in self.locations: # if the user has not entered any picked qty, set it to stock_qty, before submit - if item.picked_qty == 0: - item.picked_qty = item.stock_qty + if item.picked_qty < item.stock_qty: + frappe.msgprint( + _("Row {0} is short by {1} {2}").format( + item.idx, item.stock_qty - item.picked_qty, item.stock_uom + ), + _("Warning: Pick List Incomplete"), + indicator="yellow", + ) if item.sales_order_item: # update the picked_qty in SO Item