Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: pass necessary params instead of args

Browse Source
This commit is contained in:
Daizy Modi 2022-12-16 10:10:29 +05:30
parent 56f3ac15d8
commit 5d0b5c8d2a
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
erpnext/crm/doctype/appointment/appointment.py
View File

@ -136,9 +136,7 @@ class Appointment(Document):
if existing_assignee: if existing_assignee:
# If the latest opportunity is assigned to someone # If the latest opportunity is assigned to someone
# Assign the appointment to the same # Assign the appointment to the same
add_agent_assignment( assign_agents(self.doctype, self.name, [existing_assignee])
{"doctype": self.doctype, "name": self.name, "assign_to": [existing_assignee]}
)
return return
if self._assign: if self._assign:
return return
@ -146,7 +144,7 @@ class Appointment(Document):
for agent in available_agents: for agent in available_agents:
if _check_agent_availability(agent, self.scheduled_time): if _check_agent_availability(agent, self.scheduled_time):
agent = agent[0] agent = agent[0]
add_agent_assignment({"doctype": self.doctype, "name": self.name, "assign_to": [agent]}) assign_agents(self.doctype, self.name, [agent])
break break
def get_assignee_from_latest_opportunity(self): def get_assignee_from_latest_opportunity(self):
@ -244,12 +242,9 @@ def _get_employee_from_user(user):
return None return None
def add_agent_assignment(args): def assign_agents(doctype: str, name: str, agents: list[str]) -> None:
doctype = args.get("doctype") for agent in agents:
docname = args.get("name") if not frappe.has_permission(doctype=doctype, doc=name, user=agent):
add_docshare(doctype, name, agent, flags={"ignore_share_permission": True})
for assign_to in args.get("assign_to"): add_assignment({"doctype": doctype, "name": name, "assign_to": agents})
if not frappe.has_permission(doctype=doctype, doc=docname, user=assign_to):
add_docshare(doctype, docname, assign_to, flags={"ignore_share_permission": True})
add_assignment(args)