From 5c4df3e0e3e76116288e022db5b2cdb85d028086 Mon Sep 17 00:00:00 2001 From: Corentin Flr <10946971+cogk@users.noreply.github.com> Date: Tue, 29 Aug 2023 07:29:58 +0200 Subject: [PATCH] fix: Setup flake8 to stop turning trailing commas into tuples (#36850) --- .pre-commit-config.yaml | 1 + .../test_exchange_rate_revaluation.py | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 2c9a60c7c4..30be903ae8 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -40,6 +40,7 @@ repos: - id: flake8 additional_dependencies: [ 'flake8-bugbear', + 'flake8-tuple', ] args: ['--config', '.github/helper/.flake8_strict'] exclude: ".*setup.py$" diff --git a/erpnext/accounts/doctype/exchange_rate_revaluation/test_exchange_rate_revaluation.py b/erpnext/accounts/doctype/exchange_rate_revaluation/test_exchange_rate_revaluation.py index ced04ced3f..e520872122 100644 --- a/erpnext/accounts/doctype/exchange_rate_revaluation/test_exchange_rate_revaluation.py +++ b/erpnext/accounts/doctype/exchange_rate_revaluation/test_exchange_rate_revaluation.py @@ -67,7 +67,7 @@ class TestExchangeRateRevaluation(AccountsTestMixin, FrappeTestCase): si.save().submit() err = frappe.new_doc("Exchange Rate Revaluation") - err.company = (self.company,) + err.company = self.company err.posting_date = today() accounts = err.get_accounts_data() err.extend("accounts", accounts) @@ -133,7 +133,7 @@ class TestExchangeRateRevaluation(AccountsTestMixin, FrappeTestCase): frappe.get_doc("Journal Entry", je).cancel() err = frappe.new_doc("Exchange Rate Revaluation") - err.company = (self.company,) + err.company = self.company err.posting_date = today() err.fetch_and_calculate_accounts_data() err = err.save().submit() @@ -215,7 +215,7 @@ class TestExchangeRateRevaluation(AccountsTestMixin, FrappeTestCase): self.assertEqual(flt(acc_balance.balance_in_account_currency, precision), 5.0) # in USD err = frappe.new_doc("Exchange Rate Revaluation") - err.company = (self.company,) + err.company = self.company err.posting_date = today() err.fetch_and_calculate_accounts_data() err.set_total_gain_loss()