Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

codacy fixes

Browse Source
This commit is contained in:
Ranjith 2018-05-31 12:08:14 +05:30
parent 0cb2684130
commit 590bf4ce3a
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/hr/doctype/employee_tax_exemption_declaration/employee_tax_exemption_declaration.js
View File

@ -71,13 +71,15 @@ frappe.ui.form.on('Employee Tax Exemption Declaration', {
method: "calculate_hra_exemption", method: "calculate_hra_exemption",
doc: frm.doc, doc: frm.doc,
callback: function(r) { callback: function(r) {
frm.refresh_fields(); if (!r.exc){
frm.refresh_fields();
}
} }
}); });
}, },
set_null_value(frm){ set_null_value(frm){
let fields = ['salary_structure_hra', 'monthly_house_rent','annual_hra', 'monthly_hra', let fields = ['salary_structure_hra', 'monthly_house_rent','annual_hra', 'monthly_hra',
'total_exemption_amount', 'payroll_period']; 'total_exemption_amount', 'payroll_period'];
fields.forEach(function(field) { fields.forEach(function(field) {
frm.set_value(field, ''); frm.set_value(field, '');
}); });

1
erpnext/hr/doctype/employee_tax_exemption_declaration/employee_tax_exemption_declaration.py
View File

@ -6,7 +6,6 @@ from __future__ import unicode_literals
import frappe import frappe
from frappe.model.document import Document from frappe.model.document import Document
from frappe import _ from frappe import _
from frappe.utils import getdate
from erpnext.hr.utils import validate_tax_declaration, calculate_eligible_hra_exemption from erpnext.hr.utils import validate_tax_declaration, calculate_eligible_hra_exemption
class EmployeeTaxExemptionDeclaration(Document): class EmployeeTaxExemptionDeclaration(Document):

2
erpnext/hr/doctype/employee_tax_exemption_proof_submission/employee_tax_exemption_proof_submission.py
View File

@ -6,7 +6,7 @@ from __future__ import unicode_literals
import frappe import frappe
from frappe.model.document import Document from frappe.model.document import Document
from frappe import _ from frappe import _
from frappe.utils import date_diff, flt, getdate, get_first_day, get_last_day from frappe.utils import date_diff, flt
from erpnext.hr.utils import validate_tax_declaration, calculate_eligible_hra_exemption from erpnext.hr.utils import validate_tax_declaration, calculate_eligible_hra_exemption
class EmployeeTaxExemptionProofSubmission(Document): class EmployeeTaxExemptionProofSubmission(Document):