Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf: use LEFT JOIN instead of NOT EXISTS

Browse Source
This commit is contained in:
s-aga-r 2023-07-28 15:53:54 +05:30
parent e36c8ce5be
commit 58d867503b
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
erpnext/manufacturing/doctype/bom_update_log/bom_updation_utils.py
View File

@ -157,12 +157,19 @@ def get_next_higher_level_boms(
def get_leaf_boms() -> List[str]: def get_leaf_boms() -> List[str]:
"Get BOMs that have no dependencies." "Get BOMs that have no dependencies."
return frappe.db.sql_list( bom = frappe.qb.DocType("BOM")
"""select name from `tabBOM` bom bom_item = frappe.qb.DocType("BOM Item")
where docstatus=1 and is_active=1
and not exists(select bom_no from `tabBOM Item` boms = (
where parent=bom.name and bom_no !='')""" frappe.qb.from_(bom)
) .left_join(bom_item)
.on((bom.name == bom_item.parent) & (bom_item.bom_no != ""))
.select(bom.name)
.where((bom.docstatus == 1) & (bom.is_active == 1) & (bom_item.bom_no.isnull()))
.distinct()
).run(pluck=True)
return boms
def _generate_dependence_map() -> defaultdict: def _generate_dependence_map() -> defaultdict: