Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: identify empty values "" in against_voucher columns

Browse Source
This commit is contained in:
ruthra kumar 2022-06-21 19:50:50 +05:30
parent 9aea017990
commit 5826b7b071
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/patches/v14_0/migrate_gl_to_payment_ledger.py
View File

@ -1,6 +1,6 @@
import frappe import frappe
from frappe import qb from frappe import qb
from frappe.query_builder import Case from frappe.query_builder import Case, CustomFunction
from frappe.query_builder.custom import ConstantColumn from frappe.query_builder.custom import ConstantColumn
from frappe.query_builder.functions import IfNull from frappe.query_builder.functions import IfNull
@ -87,6 +87,7 @@ def execute():
gl = qb.DocType("GL Entry") gl = qb.DocType("GL Entry")
account = qb.DocType("Account") account = qb.DocType("Account")
ifelse = CustomFunction("IF", ["condition", "then", "else"])
gl_entries = ( gl_entries = (
qb.from_(gl) qb.from_(gl)
@ -96,8 +97,12 @@ def execute():
gl.star, gl.star,
ConstantColumn(1).as_("docstatus"), ConstantColumn(1).as_("docstatus"),
account.account_type.as_("account_type"), account.account_type.as_("account_type"),
IfNull(gl.against_voucher_type, gl.voucher_type).as_("against_voucher_type"), IfNull(
IfNull(gl.against_voucher, gl.voucher_no).as_("against_voucher_no"), ifelse(gl.against_voucher_type == "", None, gl.against_voucher_type), gl.voucher_type
).as_("against_voucher_type"),
IfNull(ifelse(gl.against_voucher == "", None, gl.against_voucher), gl.voucher_no).as_(
"against_voucher_no"
),
# convert debit/credit to amount # convert debit/credit to amount
Case() Case()
.when(account.account_type == "Receivable", gl.debit - gl.credit) .when(account.account_type == "Receivable", gl.debit - gl.credit)