Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: rewrite get_available_item_locations_for_serial_and_batched_item query in QB

Browse Source
This commit is contained in:
s-aga-r 2023-01-21 14:05:51 +05:30
parent 5b76e8b193
commit 57c3216683
1 changed files with 18 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
erpnext/stock/doctype/pick_list/pick_list.py
View File

@ -534,21 +534,24 @@ def get_available_item_locations_for_serial_and_batched_item(
item_code, from_warehouses, required_qty, company item_code, from_warehouses, required_qty, company
) )
filters = frappe._dict( if locations:
{"item_code": item_code, "company": company, "warehouse": ["!=", ""], "batch_no": ""} sn = frappe.qb.DocType("Serial No")
) conditions = (sn.item_code == item_code) & (sn.company == company)
# Get Serial Nos by FIFO for Batch No
for location in locations: for location in locations:
filters.batch_no = location.batch_no
filters.warehouse = location.warehouse
location.qty = ( location.qty = (
required_qty if location.qty > required_qty else location.qty required_qty if location.qty > required_qty else location.qty
) # if extra qty in batch ) # if extra qty in batch
serial_nos = frappe.get_list( serial_nos = (
"Serial No", fields=["name"], filters=filters, limit=location.qty, order_by="purchase_date" frappe.qb.from_(sn)
.select(sn.name)
.where(
(conditions) & (sn.batch_no == location.batch_no) & (sn.warehouse == location.warehouse)
) )
.orderby(sn.purchase_date)
.limit(cint(location.qty))
).run(as_dict=True)
serial_nos = [sn.name for sn in serial_nos] serial_nos = [sn.name for sn in serial_nos]
location.serial_no = serial_nos location.serial_no = serial_nos