[fix] remove user permission if user id is unset #3447

2015-07-03 11:34:53 +05:30 · 2015-07-03 11:34:53 +05:30 · 5688a6c31a
commit 5688a6c31a
parent b7219dc698
1 changed files with 4 additions and 0 deletions
--- a/erpnext/hr/doctype/employee/employee.py
+++ b/erpnext/hr/doctype/employee/employee.py
@ -45,6 +45,10 @@ class Employee(Document):
 		if self.user_id:
 			self.validate_for_enabled_user_id()
 			self.validate_duplicate_user_id()
+		else:
+			existing_user_id = frappe.db.get_value("Employee", self.name, "user_id")
+			if existing_user_id:
+				frappe.permissions.remove_user_permission("Employee", self.name, existing_user_id)

 	def on_update(self):
 		if self.user_id: