From 566a0a05c856e8cf1a371f1b0794389dfa98904c Mon Sep 17 00:00:00 2001 From: Rohit Waghchaure Date: Wed, 27 Sep 2017 15:57:48 +0530 Subject: [PATCH] [fix] 'NoneType' object is not iterable while saving quotation --- erpnext/accounts/doctype/tax_rule/tax_rule.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/erpnext/accounts/doctype/tax_rule/tax_rule.py b/erpnext/accounts/doctype/tax_rule/tax_rule.py index 2d91a3c85f..9c091e8c9d 100644 --- a/erpnext/accounts/doctype/tax_rule/tax_rule.py +++ b/erpnext/accounts/doctype/tax_rule/tax_rule.py @@ -8,6 +8,7 @@ from frappe import _ from frappe.model.document import Document from frappe.utils import cstr, cint from frappe.contacts.doctype.address.address import get_default_address +from frappe.utils.nestedset import get_root_of from erpnext.setup.doctype.customer_group.customer_group import get_parent_customer_groups class IncorrectCustomerGroup(frappe.ValidationError): pass @@ -136,7 +137,7 @@ def get_tax_template(posting_date, args): if key=="use_for_shopping_cart": conditions.append("use_for_shopping_cart = {0}".format(1 if value else 0)) if key == 'customer_group': - if not value: value = _("All Customer Groups") + if not value: value = get_root_of("Customer Group") customer_group_condition = get_customer_group_condition(value) conditions.append("ifnull({0}, '') in ('', {1})".format(key, customer_group_condition)) else: