From 56097807b4749e3d96d4b3f1a97dc81a82a01033 Mon Sep 17 00:00:00 2001 From: s-aga-r Date: Wed, 12 Apr 2023 13:58:11 +0530 Subject: [PATCH] fix: `Stock Reservation` validation in `Stock Settings` --- erpnext/stock/doctype/stock_settings/stock_settings.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/erpnext/stock/doctype/stock_settings/stock_settings.py b/erpnext/stock/doctype/stock_settings/stock_settings.py index f041e796d6..6e1d02c128 100644 --- a/erpnext/stock/doctype/stock_settings/stock_settings.py +++ b/erpnext/stock/doctype/stock_settings/stock_settings.py @@ -108,7 +108,9 @@ class StockSettings(Document): "Stock Settings", "enable_stock_reservation" ) - if db_enable_stock_reservation and frappe.db.count("Stock Reservation Entry"): + if db_enable_stock_reservation and frappe.db.exists( + "Stock Reservation Entry", {"docstatus": 1, "status": ["!=", "Delivered"]} + ): frappe.throw( _("As there are existing {0}, you can not change the value of {1}.").format( frappe.bold("Stock Reservation Entries"), frappe.bold("Enable Stock Reservation")