From 1ef50c89dbf9236bc89c5d354caef7c487fc137e Mon Sep 17 00:00:00 2001 From: Sagar Vora Date: Wed, 28 Jun 2017 23:52:22 +0530 Subject: [PATCH 1/2] [minor] use party_name instead of party and save GSTIN in uppercase --- .../templates/pages/regional/india/update_gstin.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/erpnext/templates/pages/regional/india/update_gstin.py b/erpnext/templates/pages/regional/india/update_gstin.py index 0d4ec37ef7..5dc4316573 100644 --- a/erpnext/templates/pages/regional/india/update_gstin.py +++ b/erpnext/templates/pages/regional/india/update_gstin.py @@ -11,16 +11,16 @@ def get_context(context): context.invalid_gstin = 1 party_type = 'Customer' - party = frappe.db.get_value('Customer', party) + party_name = frappe.db.get_value('Customer', party) - if not party: + if not party_name: party_type = 'Supplier' - party = frappe.db.get_value('Supplier', party) + party_name = frappe.db.get_value('Supplier', party) - if not party: + if not party_name: frappe.throw(_("Not Found"), frappe.DoesNotExistError) - context.party = frappe.get_doc(party_type, party) + context.party = frappe.get_doc(party_type, party_name) context.party.onload() @@ -31,7 +31,7 @@ def update_gstin(context): address_name = frappe.get_value('Address', key) if address_name: address = frappe.get_doc('Address', address_name) - address.gstin = value + address.gstin = value.upper() address.save(ignore_permissions=True) dirty = True From 435032f5bc125290811356c79367a13da293cd98 Mon Sep 17 00:00:00 2001 From: Sagar Vora Date: Wed, 28 Jun 2017 23:59:47 +0530 Subject: [PATCH 2/2] [minor] fix typo --- erpnext/regional/doctype/gst_settings/gst_settings.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/regional/doctype/gst_settings/gst_settings.py b/erpnext/regional/doctype/gst_settings/gst_settings.py index 5edb172336..45c565d193 100644 --- a/erpnext/regional/doctype/gst_settings/gst_settings.py +++ b/erpnext/regional/doctype/gst_settings/gst_settings.py @@ -83,7 +83,7 @@ def _send_gstin_reminder(party_type, party, default_email_id=None, sent_to=None)

Please help us send you GST Ready Invoices.

- Click on the here to update your GSTIN Number in our system + Click here to update your GSTIN Number in our system