Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(minor): update frappe.error_log to new API (#30864)

Browse Source 
* fix(minor): update frappe.error_log to new API

* refactor: changes for updated log_error api

Co-authored-by: Ankush Menat <ankush@frappe.io>
This commit is contained in:
Rushabh Mehta 2022-05-02 15:04:26 +05:30 committed by GitHub
parent dcda55641b
commit 548afba8bb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
33 changed files with 59 additions and 97 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
erpnext/accounts/deferred_revenue.py
View File

@ -539,19 +539,11 @@ def make_gl_entries(
frappe.db.commit() frappe.db.commit()
except Exception as e: except Exception as e:
if frappe.flags.in_test: if frappe.flags.in_test:
traceback = frappe.get_traceback() doc.log_error(f"Error while processing deferred accounting for Invoice {doc.name}")
frappe.log_error(
title=_("Error while processing deferred accounting for Invoice {0}").format(doc.name),
message=traceback,
)
raise e raise e
else: else:
frappe.db.rollback() frappe.db.rollback()
traceback = frappe.get_traceback() doc.log_error(f"Error while processing deferred accounting for Invoice {doc.name}")
frappe.log_error(
title=_("Error while processing deferred accounting for Invoice {0}").format(doc.name),
message=traceback,
)
frappe.flags.deferred_accounting_error = True frappe.flags.deferred_accounting_error = True
@ -632,12 +624,7 @@ def book_revenue_via_journal_entry(
frappe.db.commit() frappe.db.commit()
except Exception: except Exception:
frappe.db.rollback() frappe.db.rollback()
traceback = frappe.get_traceback() doc.log_error(f"Error while processing deferred accounting for Invoice {doc.name}")
frappe.log_error(
title=_("Error while processing deferred accounting for Invoice {0}").format(doc.name),
message=traceback,
)
frappe.flags.deferred_accounting_error = True frappe.flags.deferred_accounting_error = True

2
erpnext/accounts/doctype/bank_statement_import/bank_statement_import.py
View File

@ -136,7 +136,7 @@ def start_import(
except Exception: except Exception:
frappe.db.rollback() frappe.db.rollback()
data_import.db_set("status", "Error") data_import.db_set("status", "Error")
frappe.log_error(title=data_import.name) data_import.log_error("Bank Statement Import failed")
finally: finally:
frappe.flags.in_import = False frappe.flags.in_import = False

2
erpnext/accounts/doctype/bank_transaction/bank_transaction_upload.py
View File

@ -56,7 +56,7 @@ def create_bank_entries(columns, data, bank_account):
bank_transaction.submit() bank_transaction.submit()
success += 1 success += 1
except Exception: except Exception:
frappe.log_error(frappe.get_traceback()) bank_transaction.log_error("Bank entry creation failed")
errors += 1 errors += 1
return {"success": success, "errors": errors} return {"success": success, "errors": errors}

2
erpnext/accounts/doctype/ledger_merge/ledger_merge.py
View File

@ -62,7 +62,7 @@ def start_merge(docname):
) )
except Exception: except Exception:
frappe.db.rollback() frappe.db.rollback()
frappe.log_error(title=ledger_merge.name) ledger_merge.log_error("Ledger merge failed")
finally: finally:
if successful_merges == total: if successful_merges == total:
ledger_merge.db_set("status", "Success") ledger_merge.db_set("status", "Success")

9
erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.py
View File

@ -2,9 +2,6 @@
# For license information, please see license.txt # For license information, please see license.txt
import traceback
from json import dumps
import frappe import frappe
from frappe import _, scrub from frappe import _, scrub
from frappe.model.document import Document from frappe.model.document import Document
@ -247,11 +244,7 @@ def start_import(invoices):
except Exception: except Exception:
errors += 1 errors += 1
frappe.db.rollback() frappe.db.rollback()
message = "\n".join( doc.log_error("Opening invoice creation failed")
["Data:", dumps(d, default=str, indent=4), "--" * 50, "\nException:", traceback.format_exc()]
)
frappe.log_error(title="Error while creating Opening Invoice", message=message)
frappe.db.commit()
if errors: if errors:
frappe.msgprint( frappe.msgprint(
_("You had {} errors while creating opening invoices. Check {} for more details").format( _("You had {} errors while creating opening invoices. Check {} for more details").format(

4
erpnext/accounts/doctype/subscription/subscription.py
View File

@ -722,9 +722,7 @@ def process(data):
frappe.db.commit() frappe.db.commit()
except frappe.ValidationError: except frappe.ValidationError:
frappe.db.rollback() frappe.db.rollback()
frappe.db.begin() subscription.log_error("Subscription failed")
frappe.log_error(frappe.get_traceback())
frappe.db.commit()
@frappe.whitelist() @frappe.whitelist()

2
erpnext/crm/doctype/linkedin_settings/linkedin_settings.py
View File

@ -72,7 +72,7 @@ class LinkedInSettings(Document):
if media_id: if media_id:
return self.post_text(text, title, media_id=media_id) return self.post_text(text, title, media_id=media_id)
else: else:
frappe.log_error("Failed to upload media.", "LinkedIn Upload Error") self.log_error("LinkedIn: Failed to upload media")
def upload_image(self, media): def upload_image(self, media):
media = get_file_path(media) media = get_file_path(media)

3
erpnext/crm/doctype/social_media_post/social_media_post.py
View File

@ -70,8 +70,7 @@ class SocialMediaPost(Document):
except Exception: except Exception:
self.db_set("post_status", "Error") self.db_set("post_status", "Error")
title = _("Error while POSTING {0}").format(self.name) self.log_error("Social posting failed")
frappe.log_error(message=frappe.get_traceback(), title=title)
def process_scheduled_social_media_posts(): def process_scheduled_social_media_posts():

3
erpnext/e_commerce/api.py
View File

@ -56,8 +56,7 @@ def get_product_filter_data(query_args=None):
attribute_filters, field_filters, search_term=search, start=start, item_group=item_group attribute_filters, field_filters, search_term=search, start=start, item_group=item_group
) )
except Exception: except Exception:
traceback = frappe.get_traceback() frappe.log_error("Product query with filter failed")
frappe.log_error(traceback, frappe._("Product Engine Error"))
return {"exc": "Something went wrong!"} return {"exc": "Something went wrong!"}
# discount filter data # discount filter data

3
erpnext/e_commerce/redisearch_utils.py
View File

@ -245,8 +245,7 @@ def get_fields_indexed():
def raise_redisearch_error(): def raise_redisearch_error():
"Create an Error Log and raise error." "Create an Error Log and raise error."
traceback = frappe.get_traceback() log = frappe.log_error("Redisearch Error")
log = frappe.log_error(traceback, frappe._("Redisearch Error"))
log_link = frappe.utils.get_link_to_form("Error Log", log.name) log_link = frappe.utils.get_link_to_form("Error Log", log.name)
frappe.throw( frappe.throw(

2
erpnext/erpnext_integrations/connectors/woocommerce_connection.py
View File

@ -32,7 +32,7 @@ def order(*args, **kwargs):
error_message = ( error_message = (
frappe.get_traceback() + "\n\n Request Data: \n" + json.loads(frappe.request.data).__str__() frappe.get_traceback() + "\n\n Request Data: \n" + json.loads(frappe.request.data).__str__()
) )
frappe.log_error(error_message, "WooCommerce Error") frappe.log_error("WooCommerce Error", error_message)
raise raise

16
erpnext/erpnext_integrations/doctype/gocardless_settings/gocardless_settings.py
View File

@ -107,7 +107,7 @@ class GoCardlessSettings(Document):
return self.create_charge_on_gocardless() return self.create_charge_on_gocardless()
except Exception: except Exception:
frappe.log_error(frappe.get_traceback()) frappe.log_error("Gocardless payment reqeust failed")
return { return {
"redirect_to": frappe.redirect_to_message( "redirect_to": frappe.redirect_to_message(
_("Server Error"), _("Server Error"),
@ -163,21 +163,15 @@ class GoCardlessSettings(Document):
or payment.status == "charged_back" or payment.status == "charged_back"
): ):
self.integration_request.db_set("status", "Cancelled", update_modified=False) self.integration_request.db_set("status", "Cancelled", update_modified=False)
frappe.log_error( frappe.log_error("Gocardless payment cancelled")
_("Payment Cancelled. Please check your GoCardless Account for more details"),
"GoCardless Payment Error",
)
self.integration_request.db_set("error", payment.status, update_modified=False) self.integration_request.db_set("error", payment.status, update_modified=False)
else: else:
self.integration_request.db_set("status", "Failed", update_modified=False) self.integration_request.db_set("status", "Failed", update_modified=False)
frappe.log_error( frappe.log_error("Gocardless payment failed")
_("Payment Failed. Please check your GoCardless Account for more details"),
"GoCardless Payment Error",
)
self.integration_request.db_set("error", payment.status, update_modified=False) self.integration_request.db_set("error", payment.status, update_modified=False)
except Exception as e: except Exception as e:
frappe.log_error(e, "GoCardless Payment Error") frappe.log_error("GoCardless Payment Error")
if self.flags.status_changed_to == "Completed": if self.flags.status_changed_to == "Completed":
status = "Completed" status = "Completed"
@ -188,7 +182,7 @@ class GoCardlessSettings(Document):
self.data.get("reference_doctype"), self.data.get("reference_docname") self.data.get("reference_doctype"), self.data.get("reference_docname")
).run_method("on_payment_authorized", self.flags.status_changed_to) ).run_method("on_payment_authorized", self.flags.status_changed_to)
except Exception: except Exception:
frappe.log_error(frappe.get_traceback()) frappe.log_error("Gocardless redirect failed")
if custom_redirect_to: if custom_redirect_to:
redirect_to = custom_redirect_to redirect_to = custom_redirect_to

8
erpnext/erpnext_integrations/doctype/mpesa_settings/mpesa_settings.py
View File

@ -152,7 +152,7 @@ def generate_stk_push(**kwargs):
return response return response
except Exception: except Exception:
frappe.log_error(title=_("Mpesa Express Transaction Error")) frappe.log_error("Mpesa Express Transaction Error")
frappe.throw( frappe.throw(
_("Issue detected with Mpesa configuration, check the error logs for more details"), _("Issue detected with Mpesa configuration, check the error logs for more details"),
title=_("Mpesa Express Error"), title=_("Mpesa Express Error"),
@ -203,7 +203,7 @@ def verify_transaction(**kwargs):
integration_request.handle_success(transaction_response) integration_request.handle_success(transaction_response)
except Exception: except Exception:
integration_request.handle_failure(transaction_response) integration_request.handle_failure(transaction_response)
frappe.log_error(frappe.get_traceback()) frappe.log_error("Mpesa: Failed to verify transaction")
else: else:
integration_request.handle_failure(transaction_response) integration_request.handle_failure(transaction_response)
@ -275,7 +275,7 @@ def get_account_balance(request_payload):
) )
return response return response
except Exception: except Exception:
frappe.log_error(title=_("Account Balance Processing Error")) frappe.log_error("Mpesa: Failed to get account balance")
frappe.throw(_("Please check your configuration and try again"), title=_("Error")) frappe.throw(_("Please check your configuration and try again"), title=_("Error"))
@ -315,7 +315,7 @@ def process_balance_info(**kwargs):
except Exception: except Exception:
request.handle_failure(account_balance_response) request.handle_failure(account_balance_response)
frappe.log_error( frappe.log_error(
title=_("Mpesa Account Balance Processing Error"), message=account_balance_response title="Mpesa Account Balance Processing Error", message=account_balance_response
) )
else: else:
request.handle_failure(account_balance_response) request.handle_failure(account_balance_response)

10
erpnext/erpnext_integrations/doctype/plaid_settings/plaid_connector.py
View File

@ -23,7 +23,7 @@ class PlaidConnector:
def get_access_token(self, public_token): def get_access_token(self, public_token):
if public_token is None: if public_token is None:
frappe.log_error(_("Public token is missing for this bank"), _("Plaid public token error")) frappe.log_error("Plaid: Public token is missing")
response = self.client.Item.public_token.exchange(public_token) response = self.client.Item.public_token.exchange(public_token)
access_token = response["access_token"] access_token = response["access_token"]
return access_token return access_token
@ -61,10 +61,10 @@ class PlaidConnector:
try: try:
response = self.client.LinkToken.create(token_request) response = self.client.LinkToken.create(token_request)
except InvalidRequestError: except InvalidRequestError:
frappe.log_error(frappe.get_traceback(), _("Plaid invalid request error")) frappe.log_error("Plaid: Invalid request error")
frappe.msgprint(_("Please check your Plaid client ID and secret values")) frappe.msgprint(_("Please check your Plaid client ID and secret values"))
except APIError as e: except APIError as e:
frappe.log_error(frappe.get_traceback(), _("Plaid authentication error")) frappe.log_error("Plaid: Authentication error")
frappe.throw(_(str(e)), title=_("Authentication Failed")) frappe.throw(_(str(e)), title=_("Authentication Failed"))
else: else:
return response["link_token"] return response["link_token"]
@ -81,7 +81,7 @@ class PlaidConnector:
except requests.Timeout: except requests.Timeout:
pass pass
except Exception as e: except Exception as e:
frappe.log_error(frappe.get_traceback(), _("Plaid authentication error")) frappe.log_error("Plaid: Authentication error")
frappe.throw(_(str(e)), title=_("Authentication Failed")) frappe.throw(_(str(e)), title=_("Authentication Failed"))
def get_transactions(self, start_date, end_date, account_id=None): def get_transactions(self, start_date, end_date, account_id=None):
@ -102,4 +102,4 @@ class PlaidConnector:
except ItemError as e: except ItemError as e:
raise e raise e
except Exception: except Exception:
frappe.log_error(frappe.get_traceback(), _("Plaid transactions sync error")) frappe.log_error("Plaid: Transactions sync error")

6
erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.py
View File

@ -54,7 +54,7 @@ def add_institution(token, response):
) )
bank.insert() bank.insert()
except Exception: except Exception:
frappe.log_error(frappe.get_traceback(), title=_("Plaid Link Error")) frappe.log_error("Plaid Link Error")
else: else:
bank = frappe.get_doc("Bank", response["institution"]["name"]) bank = frappe.get_doc("Bank", response["institution"]["name"])
bank.plaid_access_token = access_token bank.plaid_access_token = access_token
@ -113,7 +113,7 @@ def add_bank_accounts(response, bank, company):
_("Bank account {0} already exists and could not be created again").format(account["name"]) _("Bank account {0} already exists and could not be created again").format(account["name"])
) )
except Exception: except Exception:
frappe.log_error(frappe.get_traceback(), title=_("Plaid Link Error")) frappe.log_error("Plaid Link Error")
frappe.throw( frappe.throw(
_("There was an error creating Bank Account while linking with Plaid."), _("There was an error creating Bank Account while linking with Plaid."),
title=_("Plaid Link Failed"), title=_("Plaid Link Failed"),
@ -135,7 +135,7 @@ def add_bank_accounts(response, bank, company):
existing_account.save() existing_account.save()
result.append(existing_bank_account) result.append(existing_bank_account)
except Exception: except Exception:
frappe.log_error(frappe.get_traceback(), title=_("Plaid Link Error")) frappe.log_error("Plaid Link Error")
frappe.throw( frappe.throw(
_("There was an error updating Bank Account {} while linking with Plaid.").format( _("There was an error updating Bank Account {} while linking with Plaid.").format(
existing_bank_account existing_bank_account

4
erpnext/erpnext_integrations/exotel_integration.py
View File

@ -1,6 +1,5 @@
import frappe import frappe
import requests import requests
from frappe import _
# api/method/erpnext.erpnext_integrations.exotel_integration.handle_incoming_call # api/method/erpnext.erpnext_integrations.exotel_integration.handle_incoming_call
# api/method/erpnext.erpnext_integrations.exotel_integration.handle_end_call # api/method/erpnext.erpnext_integrations.exotel_integration.handle_end_call
@ -26,8 +25,7 @@ def handle_incoming_call(**kwargs):
update_call_log(call_payload, call_log=call_log) update_call_log(call_payload, call_log=call_log)
except Exception as e: except Exception as e:
frappe.db.rollback() frappe.db.rollback()
frappe.log_error(title=_("Error in Exotel incoming call")) exotel_settings.log_error("Error in Exotel incoming call")
frappe.db.commit()
@frappe.whitelist(allow_guest=True) @frappe.whitelist(allow_guest=True)

6
erpnext/erpnext_integrations/stripe_integration.py
View File

@ -22,7 +22,7 @@ def create_stripe_subscription(gateway_controller, data):
return create_subscription_on_stripe(stripe_settings) return create_subscription_on_stripe(stripe_settings)
except Exception: except Exception:
frappe.log_error(frappe.get_traceback()) stripe_settings.log_error("Unable to create Stripe subscription")
return { return {
"redirect_to": frappe.redirect_to_message( "redirect_to": frappe.redirect_to_message(
_("Server Error"), _("Server Error"),
@ -55,9 +55,9 @@ def create_subscription_on_stripe(stripe_settings):
else: else:
stripe_settings.integration_request.db_set("status", "Failed", update_modified=False) stripe_settings.integration_request.db_set("status", "Failed", update_modified=False)
frappe.log_error("Subscription N°: " + subscription.id, "Stripe Payment not completed") frappe.log_error(f"Stripe Subscription ID {subscription.id}: Payment failed")
except Exception: except Exception:
stripe_settings.integration_request.db_set("status", "Failed", update_modified=False) stripe_settings.integration_request.db_set("status", "Failed", update_modified=False)
frappe.log_error(frappe.get_traceback()) stripe_settings.log_error("Unable to create Stripe subscription")
return stripe_settings.finalize_request() return stripe_settings.finalize_request()

2
erpnext/manufacturing/doctype/bom_update_log/bom_update_log.py
View File

@ -154,7 +154,7 @@ def run_bom_job(
except Exception: except Exception:
frappe.db.rollback() frappe.db.rollback()
error_log = frappe.log_error(message=frappe.get_traceback(), title=_("BOM Update Tool Error")) error_log = doc.log_error("BOM Update Tool Error")
doc.db_set("status", "Failed") doc.db_set("status", "Failed")
doc.db_set("error_log", error_log.name) doc.db_set("error_log", error_log.name)

2
erpnext/patches/v12_0/move_bank_account_swift_number_to_bank.py
View File

@ -17,7 +17,7 @@ def execute():
""" """
) )
except Exception as e: except Exception as e:
frappe.log_error(e, title="Patch Migration Failed") frappe.log_error("Bank to Bank Account patch migration failed")
frappe.reload_doc("accounts", "doctype", "bank_account") frappe.reload_doc("accounts", "doctype", "bank_account")
frappe.reload_doc("accounts", "doctype", "payment_request") frappe.reload_doc("accounts", "doctype", "payment_request")

3
erpnext/patches/v13_0/add_missing_fg_item_for_stock_entry.py
View File

@ -96,8 +96,7 @@ def repost_stock_entry(doc):
make_sl_entries(sl_entries, True) make_sl_entries(sl_entries, True)
except Exception: except Exception:
print(f"SLE entries not posted for the stock entry {doc.name}") print(f"SLE entries not posted for the stock entry {doc.name}")
traceback = frappe.get_traceback() doc.log_error("Stock respost failed")
frappe.log_error(traceback)
def get_sle_for_target_warehouse(doc, sl_entries, finished_item_row): def get_sle_for_target_warehouse(doc, sl_entries, finished_item_row):

5
erpnext/patches/v13_0/convert_to_website_item_in_item_card_group_template.py
View File

@ -56,8 +56,5 @@ def make_new_website_item(item: str) -> Union[str, None]:
web_item = make_website_item(doc) # returns [website_item.name, item_name] web_item = make_website_item(doc) # returns [website_item.name, item_name]
return web_item[0] return web_item[0]
except Exception: except Exception:
title = f"{item}: Error while converting to Website Item " doc.log_error("Website Item creation failed")
frappe.log_error(
title + "for Item Card Group Template" + "\n\n" + frappe.get_traceback(), title=title
)
return None return None

5
erpnext/patches/v13_0/modify_invalid_gain_loss_gl_entries.py
View File

@ -40,7 +40,10 @@ def execute():
) )
if purchase_invoices + sales_invoices: if purchase_invoices + sales_invoices:
frappe.log_error(json.dumps(purchase_invoices + sales_invoices, indent=2), title="Patch Log") frappe.log_error(
"Fix invalid gain / loss patch log",
message=json.dumps(purchase_invoices + sales_invoices, indent=2),
)
acc_frozen_upto = frappe.db.get_value("Accounts Settings", None, "acc_frozen_upto") acc_frozen_upto = frappe.db.get_value("Accounts Settings", None, "acc_frozen_upto")
if acc_frozen_upto: if acc_frozen_upto:

2
erpnext/patches/v14_0/rename_ongoing_status_in_sla_documents.py
View File

@ -18,4 +18,4 @@ def execute():
).run() ).run()
except Exception: except Exception:
frappe.log_error(title="Failed to Patch SLA Status") frappe.log_error("Failed to Patch SLA Status")

6
erpnext/regional/doctype/import_supplier_invoice/import_supplier_invoice.py
View File

@ -160,7 +160,7 @@ def get_file_content(file_name, zip_file_object):
try: try:
content = encoded_content.decode("utf-16") content = encoded_content.decode("utf-16")
except UnicodeDecodeError as e: except UnicodeDecodeError as e:
frappe.log_error(message=e, title="UTF-16 encoding error for File Name: " + file_name) frappe.log_error("UTF-16 encoding error for File Name: " + file_name)
return content return content
@ -390,9 +390,7 @@ def create_purchase_invoice(supplier_name, file_name, args, name):
return pi.name return pi.name
except Exception as e: except Exception as e:
frappe.db.set_value("Import Supplier Invoice", name, "status", "Error") frappe.db.set_value("Import Supplier Invoice", name, "status", "Error")
frappe.log_error( pi.log_error("Unable to create Puchase Invoice")
message=e, title="Create Purchase Invoice: " + args.get("bill_no") + "File Name: " + file_name
)
return None return None

2
erpnext/setup/doctype/company/company.py
View File

@ -528,7 +528,7 @@ def install_country_fixtures(company, country):
except ImportError: except ImportError:
pass pass
except Exception: except Exception:
frappe.log_error() frappe.log_error("Unable to set country fixtures")
frappe.throw( frappe.throw(
_("Failed to setup defaults for country {0}. Please contact support.").format( _("Failed to setup defaults for country {0}. Please contact support.").format(
frappe.bold(country) frappe.bold(country)

2
erpnext/setup/setup_wizard/operations/taxes_setup.py
View File

@ -116,7 +116,7 @@ def update_regional_tax_settings(country, company):
frappe.get_attr(module_name)(country, company) frappe.get_attr(module_name)(country, company)
except Exception as e: except Exception as e:
# Log error and ignore if failed to setup regional tax settings # Log error and ignore if failed to setup regional tax settings
frappe.log_error() frappe.log_error("Unable to setup regional tax settings")
pass pass

2
erpnext/setup/utils.py
View File

@ -112,7 +112,7 @@ def get_exchange_rate(from_currency, to_currency, transaction_date=None, args=No
cache.setex(name=key, time=21600, value=flt(value)) cache.setex(name=key, time=21600, value=flt(value))
return flt(value) return flt(value)
except Exception: except Exception:
frappe.log_error(title="Get Exchange Rate") frappe.log_error("Unable to fetch exchange rate")
frappe.msgprint( frappe.msgprint(
_( _(
"Unable to find exchange rate for {0} to {1} for key date {2}. Please create a Currency Exchange record manually" "Unable to find exchange rate for {0} to {1} for key date {2}. Please create a Currency Exchange record manually"

2
erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py
View File

@ -135,7 +135,7 @@ def repost(doc):
except Exception: except Exception:
frappe.db.rollback() frappe.db.rollback()
traceback = frappe.get_traceback() traceback = frappe.get_traceback()
frappe.log_error(traceback) doc.log_error("Unable to repost item valuation")
message = frappe.message_log.pop() if frappe.message_log else "" message = frappe.message_log.pop() if frappe.message_log else ""
if traceback: if traceback:

6
erpnext/stock/reorder_item.py
View File

@ -136,14 +136,14 @@ def create_material_request(material_requests):
mr_list = [] mr_list = []
exceptions_list = [] exceptions_list = []
def _log_exception(): def _log_exception(mr):
if frappe.local.message_log: if frappe.local.message_log:
exceptions_list.extend(frappe.local.message_log) exceptions_list.extend(frappe.local.message_log)
frappe.local.message_log = [] frappe.local.message_log = []
else: else:
exceptions_list.append(frappe.get_traceback()) exceptions_list.append(frappe.get_traceback())
frappe.log_error(frappe.get_traceback()) mr.log_error("Unable to create material request")
for request_type in material_requests: for request_type in material_requests:
for company in material_requests[request_type]: for company in material_requests[request_type]:
@ -207,7 +207,7 @@ def create_material_request(material_requests):
mr_list.append(mr) mr_list.append(mr)
except Exception: except Exception:
_log_exception() _log_exception(mr)
if mr_list: if mr_list:
if getattr(frappe.local, "reorder_email_notify", None) is None: if getattr(frappe.local, "reorder_email_notify", None) is None:

2
erpnext/templates/pages/integrations/gocardless_checkout.py
View File

@ -96,5 +96,5 @@ def check_mandate(data, reference_doctype, reference_docname):
return {"redirect_to": redirect_flow.redirect_url} return {"redirect_to": redirect_flow.redirect_url}
except Exception as e: except Exception as e:
frappe.log_error(e, "GoCardless Payment Error") frappe.log_error("GoCardless Payment Error")
return {"redirect_to": "/integrations/payment-failed"} return {"redirect_to": "/integrations/payment-failed"}

6
erpnext/templates/pages/integrations/gocardless_confirmation.py
View File

@ -60,7 +60,7 @@ def confirm_payment(redirect_flow_id, reference_doctype, reference_docname):
try: try:
create_mandate(data) create_mandate(data)
except Exception as e: except Exception as e:
frappe.log_error(e, "GoCardless Mandate Registration Error") frappe.log_error("GoCardless Mandate Registration Error")
gateway_controller = get_gateway_controller(reference_docname) gateway_controller = get_gateway_controller(reference_docname)
frappe.get_doc("GoCardless Settings", gateway_controller).create_payment_request(data) frappe.get_doc("GoCardless Settings", gateway_controller).create_payment_request(data)
@ -68,7 +68,7 @@ def confirm_payment(redirect_flow_id, reference_doctype, reference_docname):
return {"redirect_to": confirmation_url} return {"redirect_to": confirmation_url}
except Exception as e: except Exception as e:
frappe.log_error(e, "GoCardless Payment Error") frappe.log_error("GoCardless Payment Error")
return {"redirect_to": "/integrations/payment-failed"} return {"redirect_to": "/integrations/payment-failed"}
@ -103,4 +103,4 @@ def create_mandate(data):
).insert(ignore_permissions=True) ).insert(ignore_permissions=True)
except Exception: except Exception:
frappe.log_error(frappe.get_traceback()) frappe.log_error("Gocardless: Unable to create mandate")

6
erpnext/utilities/doctype/video/video.py
View File

@ -36,8 +36,7 @@ class Video(Document):
self.comment_count = video_stats.get("commentCount") self.comment_count = video_stats.get("commentCount")
except Exception: except Exception:
title = "Failed to Update YouTube Statistics for Video: {0}".format(self.name) self.log_error("Unable to update YouTube statistics")
frappe.log_error(title + "\n\n" + frappe.get_traceback(), title=title)
def is_tracking_enabled(): def is_tracking_enabled():
@ -109,8 +108,7 @@ def batch_update_youtube_data():
video_stats = video.items video_stats = video.items
return video_stats return video_stats
except Exception: except Exception:
title = "Failed to Update YouTube Statistics" frappe.log_error("Unable to update YouTube statistics")
frappe.log_error(title + "\n\n" + frappe.get_traceback(), title=title)
def prepare_and_set_data(video_list): def prepare_and_set_data(video_list):
video_ids = get_formatted_ids(video_list) video_ids = get_formatted_ids(video_list)

2
erpnext/utilities/doctype/video_settings/video_settings.py
View File

@ -18,5 +18,5 @@ class VideoSettings(Document):
build("youtube", "v3", developerKey=self.api_key) build("youtube", "v3", developerKey=self.api_key)
except Exception: except Exception:
title = _("Failed to Authenticate the API key.") title = _("Failed to Authenticate the API key.")
frappe.log_error(title + "\n\n" + frappe.get_traceback(), title=title) self.log_error("Failed to authenticate API key")
frappe.throw(title + " Please check the error logs.", title=_("Invalid Credentials")) frappe.throw(title + " Please check the error logs.", title=_("Invalid Credentials"))