Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: condition for SLA status banner

Browse Source 
If the document is NOT in the closed state and fulfilled then there
won't be any banner. This bug was introduced while fixing a bug related
to buttons, so separated out code for showing buttons and showing
banners.
This commit is contained in:
Ankush Menat 2021-04-09 17:14:37 +05:30
parent 526f76c27d
commit 5451bbf7d2
No known key found for this signature in database
GPG Key ID: 8EA82E09BBD13AAF
1 changed files with 52 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
erpnext/support/doctype/issue/issue.js
View File

@ -49,8 +49,10 @@ frappe.ui.form.on("Issue", {
},
refresh: function(frm) {
if (frm.doc.status !== "Closed") {
if (frm.doc.service_level_agreement && frm.doc.agreement_status === "Ongoing") {
// alert messages
if (frm.doc.status !== "Closed" && frm.doc.service_level_agreement
&& frm.doc.agreement_status === "Ongoing") {
frappe.call({
"method": "frappe.client.get",
args: {
@ -78,22 +80,7 @@ frappe.ui.form.on("Issue", {
}
}
});
}
frm.add_custom_button(__("Close"), function () {
frm.set_value("status", "Closed");
frm.save();
});
frm.add_custom_button(__("Task"), function () {
frappe.model.open_mapped_doc({
method: "erpnext.support.doctype.issue.issue.make_task",
frm: frm
});
}, __("Create"));
} else {
if (frm.doc.service_level_agreement) {
} else if (frm.doc.service_level_agreement) {
frm.dashboard.clear_headline();
let agreement_status = (frm.doc.agreement_status == "Fulfilled") ?
@ -109,6 +96,21 @@ frappe.ui.form.on("Issue", {
);
}
// buttons
if (frm.doc.status !== "Closed") {
frm.add_custom_button(__("Close"), function() {
frm.set_value("status", "Closed");
frm.save();
});
frm.add_custom_button(__("Task"), function() {
frappe.model.open_mapped_doc({
method: "erpnext.support.doctype.issue.issue.make_task",
frm: frm
});
}, __("Create"));
} else {
frm.add_custom_button(__("Reopen"), function() {
frm.set_value("status", "Open");
frm.save();