Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: check child rows before update

Browse Source
This commit is contained in:
Gursheen Anand 2023-10-12 16:54:41 +05:30
parent e2cccc4005
commit 528ed9c986
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/controllers/accounts_controller.py
View File

@ -3251,17 +3251,14 @@ def update_child_qty_rate(parent_doctype, trans_items, parent_doctype_name, chil
def check_if_child_table_updated( def check_if_child_table_updated(
child_table_before_update, child_table_after_update, fields_to_check child_table_before_update, child_table_after_update, fields_to_check
): ):
accounting_dimensions = get_accounting_dimensions() + ["cost_center", "project"] fields_to_check = list(fields_to_check) + get_accounting_dimensions() + ["cost_center", "project"]
# Check if any field affecting accounting entry is altered # Check if any field affecting accounting entry is altered
for index, item in enumerate(child_table_after_update): for index, item in enumerate(child_table_before_update):
for field in fields_to_check: for field in fields_to_check:
if child_table_before_update[index].get(field) != item.get(field): if child_table_before_update[index].get(field) != item.get(field):
return True return True
for dimension in accounting_dimensions:
if child_table_before_update[index].get(dimension) != item.get(dimension):
return True
return False return False