Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: make response handling more descriptive

Browse Source
This commit is contained in:
Mangesh-Khairnar 2020-10-13 17:10:16 +05:30
parent faa0cce7a7
commit 51228b5ee3
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/accounts/doctype/payment_request/payment_request.py
View File

@ -186,7 +186,7 @@ class PaymentRequest(Document):
party_amount = self.grand_total
payment_entry = get_payment_entry(self.reference_doctype, self.reference_name, party_amount=party_amount,
bank_account=self.payment_account, bank_amount=bank_amount, mode_of_payment=self.mode_of_payment)
bank_account=self.payment_account, bank_amount=bank_amount)
payment_entry.update({
"reference_no": self.name,

12
erpnext/erpnext_integrations/doctype/mpesa_settings/mpesa_settings.py
View File

@ -109,13 +109,13 @@ def verify_transaction(**kwargs):
item_response = transaction_response["CallbackMetadata"]["Item"]
mpesa_receipt = fetch_param_value(item_response, "MpesaReceiptNumber", "Name")
frappe.db.set_value("POS Invoice", doc.reference_name, "mpesa_receipt_number", mpesa_receipt)
request.process_response('output', transaction_response)
request.handle_success(transaction_response)
except Exception:
request.process_response('error', transaction_response)
request.handle_failure(transaction_response)
frappe.log_error(frappe.get_traceback())
else:
request.process_response('error', transaction_response)
request.handle_failure(transaction_response)
frappe.publish_realtime('process_phone_payment', doctype="POS Invoice",
docname=transaction_data.payment_reference, user=request.owner, message=transaction_response)
@ -162,12 +162,12 @@ def process_balance_info(**kwargs):
ref_doc = frappe.get_doc(transaction_data.reference_doctype, transaction_data.reference_docname)
ref_doc.db_set("account_balance", balance_info)
request.process_response('output', account_balance_response)
request.handle_success(account_balance_response)
except:
request.process_response('error', account_balance_response)
request.handle_failure(account_balance_response)
frappe.log_error(title=_("Mpesa Account Balance Processing Error"), message=account_balance_response)
else:
request.process_response('error', account_balance_response)
request.handle_failure(account_balance_response)
def convert_to_json(balance_info):
"""