Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(DX): capture tracebacks with context (#39060)

Browse Source
This commit is contained in:
Ankush Menat 2024-01-01 13:10:03 +05:30 committed by GitHub
parent 0346f47c1d
commit 510fdf7bf6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/accounts/doctype/process_payment_reconciliation/process_payment_reconciliation.py
View File

@ -440,7 +440,7 @@ def reconcile(doc: None | str = None) -> None:
# Update the parent doc about the exception # Update the parent doc about the exception
frappe.db.rollback() frappe.db.rollback()
traceback = frappe.get_traceback() traceback = frappe.get_traceback(with_context=True)
if traceback: if traceback:
message = "Traceback: <br>" + traceback message = "Traceback: <br>" + traceback
frappe.db.set_value("Process Payment Reconciliation Log", log, "error_log", message) frappe.db.set_value("Process Payment Reconciliation Log", log, "error_log", message)

2
erpnext/accounts/doctype/repost_payment_ledger/repost_payment_ledger.py
View File

@ -43,7 +43,7 @@ def start_payment_ledger_repost(docname=None):
except Exception as e: except Exception as e:
frappe.db.rollback() frappe.db.rollback()
traceback = frappe.get_traceback() traceback = frappe.get_traceback(with_context=True)
if traceback: if traceback:
message = "Traceback: <br>" + traceback message = "Traceback: <br>" + traceback
frappe.db.set_value(repost_doc.doctype, repost_doc.name, "repost_error_log", message) frappe.db.set_value(repost_doc.doctype, repost_doc.name, "repost_error_log", message)

2
erpnext/manufacturing/doctype/bom_creator/bom_creator.py
View File

@ -251,7 +251,7 @@ class BOMCreator(Document):
frappe.msgprint(_("BOMs created successfully")) frappe.msgprint(_("BOMs created successfully"))
except Exception: except Exception:
traceback = frappe.get_traceback() traceback = frappe.get_traceback(with_context=True)
self.db_set( self.db_set(
{ {
"status": "Failed", "status": "Failed",

4
erpnext/stock/doctype/closing_stock_balance/closing_stock_balance.py
View File

@ -149,6 +149,4 @@ def prepare_closing_stock_balance(name):
doc.db_set("status", "Completed") doc.db_set("status", "Completed")
except Exception as e: except Exception as e:
doc.db_set("status", "Failed") doc.db_set("status", "Failed")
traceback = frappe.get_traceback() doc.log_error(title="Closing Stock Balance Failed")
frappe.log_error("Closing Stock Balance Failed", traceback, doc.doctype, doc.name)

2
erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py
View File

@ -294,7 +294,7 @@ def repost(doc):
raise raise
frappe.db.rollback() frappe.db.rollback()
traceback = frappe.get_traceback() traceback = frappe.get_traceback(with_context=True)
doc.log_error("Unable to repost item valuation") doc.log_error("Unable to repost item valuation")
message = frappe.message_log.pop() if frappe.message_log else "" message = frappe.message_log.pop() if frappe.message_log else ""

2
erpnext/stock/reorder_item.py
View File

@ -141,7 +141,7 @@ def create_material_request(material_requests):
exceptions_list.extend(frappe.local.message_log) exceptions_list.extend(frappe.local.message_log)
frappe.local.message_log = [] frappe.local.message_log = []
else: else:
exceptions_list.append(frappe.get_traceback()) exceptions_list.append(frappe.get_traceback(with_context=True))
mr.log_error("Unable to create material request") mr.log_error("Unable to create material request")

4
erpnext/utilities/bulk_transaction.py
View File

@ -62,7 +62,7 @@ def retry_failed_transactions(failed_docs: list | None):
task(log.transaction_name, log.from_doctype, log.to_doctype) task(log.transaction_name, log.from_doctype, log.to_doctype)
except Exception as e: except Exception as e:
frappe.db.rollback(save_point="before_creation_state") frappe.db.rollback(save_point="before_creation_state")
update_log(log.name, "Failed", 1, str(frappe.get_traceback())) update_log(log.name, "Failed", 1, str(frappe.get_traceback(with_context=True)))
else: else:
update_log(log.name, "Success", 1) update_log(log.name, "Success", 1)
@ -86,7 +86,7 @@ def job(deserialized_data, from_doctype, to_doctype):
fail_count += 1 fail_count += 1
create_log( create_log(
doc_name, doc_name,
str(frappe.get_traceback()), str(frappe.get_traceback(with_context=True)),
from_doctype, from_doctype,
to_doctype, to_doctype,
status="Failed", status="Failed",