From 4f1a7e5aa8c12fc74e8090dd87e6e0c4213edefe Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Mon, 11 May 2015 15:22:43 +0530 Subject: [PATCH] [fix] newsletter list duplicate --- erpnext/crm/doctype/newsletter_list/newsletter_list.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/erpnext/crm/doctype/newsletter_list/newsletter_list.py b/erpnext/crm/doctype/newsletter_list/newsletter_list.py index 4f89c9ab63..ba0eec7e12 100644 --- a/erpnext/crm/doctype/newsletter_list/newsletter_list.py +++ b/erpnext/crm/doctype/newsletter_list/newsletter_list.py @@ -68,7 +68,8 @@ def add_subscribers(name, email_list): validate_email_add(email, True) if email: - try: + if not frappe.db.get_value("Newsletter List Subscriber", + {"newsletter_list": name, "email": email}): frappe.get_doc({ "doctype": "Newsletter List Subscriber", "newsletter_list": name, @@ -76,10 +77,8 @@ def add_subscribers(name, email_list): }).insert() count += 1 - except Exception, e: - # ignore duplicate - if e.args[0] != 1062: - raise + else: + pass frappe.msgprint(_("{0} subscribers added").format(count))