From 4ec85cb2f0715528fb4888846fc9c27b2d98347f Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Fri, 8 Jul 2022 19:28:03 +0530 Subject: [PATCH] test: don't silently fail reposts in tests (#31559) --- .../doctype/repost_item_valuation/repost_item_valuation.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py b/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py index b1017d2c9c..7c57ecd73e 100644 --- a/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py +++ b/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py @@ -138,6 +138,11 @@ def repost(doc): doc.set_status("Completed") except Exception as e: + if frappe.flags.in_test: + # Don't silently fail in tests, + # there is no reason for reposts to fail in CI + raise + frappe.db.rollback() traceback = frappe.get_traceback() doc.log_error("Unable to repost item valuation")