Merge branch 'contacts-ref' of https://github.com/deepeshgarg007/erpnext into contacts-ref

erpnext/hr/doctype/loan_application/loan_application.py

@@ -30,7 +30,7 @@ class LoanApplication(Document):
 			monthly_interest_rate = flt(self.rate_of_interest) / (12 *100)
 			if monthly_interest_rate:
 				min_repayment_amount = self.loan_amount*monthly_interest_rate
-				if self.repayment_amount - min_repayment_amount <= 0:
+				if (self.repayment_amount - min_repayment_amount) <= 0:
 					frappe.throw(_("Repayment Amount must be greater than " \
 						+ str(flt(min_repayment_amount, 2))))
 				self.repayment_periods = math.ceil((math.log(self.repayment_amount) -
@@ -58,10 +58,13 @@ def make_loan(source_name, target_doc = None):
 	doclist = get_mapped_doc("Loan Application", source_name, {
 		"Loan Application": {
 			"doctype": "Loan",
+			"field_map": {
+				"repayment_amount": "monthly_repayment_amount"
+			},
 			"validation": {
 				"docstatus": ["=", 1]
 			}
 		}
 	}, target_doc)
 
-	return doclist
+	return doclist

erpnext/setup/doctype/item_group/item_group.py

@@ -27,7 +27,7 @@ class ItemGroup(NestedSet, WebsiteGenerator):
 	def validate(self):
 		super(ItemGroup, self).validate()
 
-		if not self.parent_item_group:
+		if not self.parent_item_group and not frappe.flags.in_test:
 			self.parent_item_group = 'All Item Groups'
 
 		self.make_route()