Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: make Sales Person non-mandatory

Browse Source
This commit is contained in:
s-aga-r 2024-01-05 18:44:06 +05:30
parent 351ee5b8fe
commit 4d56f725fe
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/maintenance/doctype/maintenance_schedule/maintenance_schedule.py
View File

@ -117,7 +117,7 @@ class MaintenanceSchedule(TransactionBase):
self.update_amc_date(serial_nos, d.end_date) self.update_amc_date(serial_nos, d.end_date)
no_email_sp = [] no_email_sp = []
if d.sales_person not in email_map: if d.sales_person and d.sales_person not in email_map:
sp = frappe.get_doc("Sales Person", d.sales_person) sp = frappe.get_doc("Sales Person", d.sales_person)
try: try:
email_map[d.sales_person] = sp.get_email_id() email_map[d.sales_person] = sp.get_email_id()
@ -133,9 +133,9 @@ class MaintenanceSchedule(TransactionBase):
scheduled_date = frappe.db.sql( scheduled_date = frappe.db.sql(
"""select scheduled_date from """select scheduled_date from
`tabMaintenance Schedule Detail` where sales_person=%s and item_code=%s and `tabMaintenance Schedule Detail` where item_code=%s and
parent=%s""", parent=%s""",
(d.sales_person, d.item_code, self.name), (d.item_code, self.name),
as_dict=1, as_dict=1,
) )
@ -232,8 +232,6 @@ class MaintenanceSchedule(TransactionBase):
throw(_("Please select Start Date and End Date for Item {0}").format(d.item_code)) throw(_("Please select Start Date and End Date for Item {0}").format(d.item_code))
elif not d.no_of_visits: elif not d.no_of_visits:
throw(_("Please mention no of visits required")) throw(_("Please mention no of visits required"))
elif not d.sales_person:
throw(_("Please select a Sales Person for item: {0}").format(d.item_name))
if getdate(d.start_date) >= getdate(d.end_date): if getdate(d.start_date) >= getdate(d.end_date):
throw(_("Start date should be less than end date for Item {0}").format(d.item_code)) throw(_("Start date should be less than end date for Item {0}").format(d.item_code))