From 4c614bd59a6f34743545004d6ff49e9098adbc7f Mon Sep 17 00:00:00 2001 From: Neil Trini Lasrado Date: Mon, 24 Aug 2015 15:12:34 +0530 Subject: [PATCH] Fixed validation for numeric variants to check with values from template instead of master --- erpnext/stock/doctype/item/item.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/erpnext/stock/doctype/item/item.py b/erpnext/stock/doctype/item/item.py index 379da18934..659fb1b5f5 100644 --- a/erpnext/stock/doctype/item/item.py +++ b/erpnext/stock/doctype/item/item.py @@ -513,9 +513,10 @@ def validate_item_variant_attributes(item, args): filters={"parent": ["in", args.keys()]}): (attribute_values.setdefault(t.parent, [])).append(t.attribute_value) - numeric_attributes = frappe._dict((t.name, t) for t in frappe.get_list("Item Attribute", filters={"numeric_values":1, - "name": ["in", args.keys()]}, fields=["name", "from_range", "to_range", "increment"])) - + numeric_attributes = frappe._dict((t.attribute, t) for t in \ + frappe.db.sql("""select attribute, from_range, to_range, increment from `tabItem Variant Attribute` + where parent = %s and numeric_values=1""", (item), as_dict=1)) + for attribute, value in args.items(): if attribute in numeric_attributes: