Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix:Sibling child table filtering for duplacacy on student form

Browse Source
This commit is contained in:
Khushal Trivedi 2019-12-11 15:16:56 +05:30
parent 57664442e4
commit 4c24fb1efc
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/education/doctype/student/student.js
View File

@ -33,7 +33,6 @@ frappe.ui.form.on('Student Guardian', {
frm.fields_dict['guardians'].grid.get_field('guardian').get_query = function(doc){
let guardian_list = [];
if(!doc.__islocal) guardian_list.push(doc.guardian);
$.each(doc.guardians, function(idx, val){
if (val.guardian) guardian_list.push(val.guardian);
});
@ -48,12 +47,10 @@ frappe.ui.form.on('Student Sibling', {
frm.fields_dict['siblings'].grid.get_field('student').get_query = function(doc){
let sibling_list = [frm.doc.name];
if(!doc.__islocal) sibling_list.push(doc.student);
$.each(doc.siblings, function(idx, val){
if (val.student && val.studying_in_same_institute == 'YES') {
sibling_list.push(val.student);
}
}
});
return { filters: [['Student', 'name', 'not in', sibling_list]] };
};