Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: agent assignment and permissions for appointment

Browse Source
This commit is contained in:
Daizy Modi 2022-12-15 17:19:28 +05:30
parent ac51c27500
commit 4bfe2ea572
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
erpnext/crm/doctype/appointment/appointment.py
View File

@ -6,7 +6,9 @@ from collections import Counter
import frappe import frappe
from frappe import _ from frappe import _
from frappe.desk.form.assign_to import add as add_assignment
from frappe.model.document import Document from frappe.model.document import Document
from frappe.share import add_docshare
from frappe.utils import get_url, getdate, now from frappe.utils import get_url, getdate, now
from frappe.utils.verified_command import get_signed_params from frappe.utils.verified_command import get_signed_params
@ -130,13 +132,13 @@ class Appointment(Document):
self.party = lead.name self.party = lead.name
def auto_assign(self): def auto_assign(self):
from frappe.desk.form.assign_to import add as add_assignemnt
existing_assignee = self.get_assignee_from_latest_opportunity() existing_assignee = self.get_assignee_from_latest_opportunity()
if existing_assignee: if existing_assignee:
# If the latest opportunity is assigned to someone # If the latest opportunity is assigned to someone
# Assign the appointment to the same # Assign the appointment to the same
add_assignemnt({"doctype": self.doctype, "name": self.name, "assign_to": [existing_assignee]}) add_agent_assignment(
{"doctype": self.doctype, "name": self.name, "assign_to": [existing_assignee]}
)
return return
if self._assign: if self._assign:
return return
@ -144,7 +146,7 @@ class Appointment(Document):
for agent in available_agents: for agent in available_agents:
if _check_agent_availability(agent, self.scheduled_time): if _check_agent_availability(agent, self.scheduled_time):
agent = agent[0] agent = agent[0]
add_assignemnt({"doctype": self.doctype, "name": self.name, "assign_to": [agent]}) add_agent_assignment({"doctype": self.doctype, "name": self.name, "assign_to": [agent]})
break break
def get_assignee_from_latest_opportunity(self): def get_assignee_from_latest_opportunity(self):
@ -201,7 +203,7 @@ class Appointment(Document):
def _get_agents_sorted_by_asc_workload(date): def _get_agents_sorted_by_asc_workload(date):
appointments = frappe.db.get_list("Appointment", fields="*") appointments = frappe.get_all("Appointment", fields="*")
agent_list = _get_agent_list_as_strings() agent_list = _get_agent_list_as_strings()
if not appointments: if not appointments:
return agent_list return agent_list
@ -226,7 +228,7 @@ def _get_agent_list_as_strings():
def _check_agent_availability(agent_email, scheduled_time): def _check_agent_availability(agent_email, scheduled_time):
appointemnts_at_scheduled_time = frappe.get_list( appointemnts_at_scheduled_time = frappe.get_all(
"Appointment", filters={"scheduled_time": scheduled_time} "Appointment", filters={"scheduled_time": scheduled_time}
) )
for appointment in appointemnts_at_scheduled_time: for appointment in appointemnts_at_scheduled_time:
@ -240,3 +242,12 @@ def _get_employee_from_user(user):
if employee_docname: if employee_docname:
return frappe.get_doc("Employee", employee_docname) return frappe.get_doc("Employee", employee_docname)
return None return None
def add_agent_assignment(args):
doc = frappe.get_cached_doc(args.get("doctype"), args.get("name"))
for assign_to in args.get("assign_to"):
if not frappe.has_permission(doc=doc, user=assign_to):
add_docshare(doc.doctype, doc.name, assign_to, flags={"ignore_share_permission": True})
add_assignment(args)