From 4a8ed9025561c76c1016df6ee6d9b5fd0f302117 Mon Sep 17 00:00:00 2001 From: Joe Paul Date: Mon, 27 May 2019 14:11:52 +0530 Subject: [PATCH] fix(subscription): Remove property decorator (#17395) --- erpnext/accounts/doctype/subscription/subscription.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/erpnext/accounts/doctype/subscription/subscription.py b/erpnext/accounts/doctype/subscription/subscription.py index 2bb2c004af..858359eccb 100644 --- a/erpnext/accounts/doctype/subscription/subscription.py +++ b/erpnext/accounts/doctype/subscription/subscription.py @@ -314,13 +314,11 @@ class Subscription(Document): self.save() - @property def is_postpaid_to_invoice(self): return getdate(nowdate()) > getdate(self.current_invoice_end) or \ (getdate(nowdate()) >= getdate(self.current_invoice_end) and getdate(self.current_invoice_end) == getdate(self.current_invoice_start)) and \ not self.has_outstanding_invoice() - @property def is_prepaid_to_invoice(self): if not self.generate_invoice_at_period_start: return False @@ -340,7 +338,7 @@ class Subscription(Document): 2. Change the `Subscription` status to 'Past Due Date' 3. Change the `Subscription` status to 'Cancelled' """ - if self.is_postpaid_to_invoice or self.is_prepaid_to_invoice: + if self.is_postpaid_to_invoice() or self.is_prepaid_to_invoice(): self.generate_invoice() if self.current_invoice_is_past_due(): self.status = 'Past Due Date'