From 4a19c1c19d23bd833d845631a0ddc8a04141a32d Mon Sep 17 00:00:00 2001 From: Devin Slauenwhite Date: Wed, 4 May 2022 10:29:52 -0400 Subject: [PATCH] Revert "fix(test): manually select picked_qty since before_submit validates qty instead of auto filling it" This reverts commit c2335ec0 --- erpnext/stock/doctype/pick_list/test_pick_list.py | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/erpnext/stock/doctype/pick_list/test_pick_list.py b/erpnext/stock/doctype/pick_list/test_pick_list.py index 1c90f32b37..f552299806 100644 --- a/erpnext/stock/doctype/pick_list/test_pick_list.py +++ b/erpnext/stock/doctype/pick_list/test_pick_list.py @@ -411,8 +411,6 @@ class TestPickList(FrappeTestCase): } ) pick_list.set_item_locations() - for location in pick_list.locations: - location.picked_qty = location.stock_qty pick_list.submit() delivery_note = create_delivery_note(pick_list.name) @@ -529,8 +527,6 @@ class TestPickList(FrappeTestCase): } ) pick_list.set_item_locations() - for location in pick_list.locations: - location.picked_qty = location.stock_qty pick_list.submit() create_delivery_note(pick_list.name) for dn in frappe.get_all( @@ -575,8 +571,6 @@ class TestPickList(FrappeTestCase): } ) pick_list_1.set_item_locations() - for location in pick_list_1.locations: - location.picked_qty = location.stock_qty pick_list_1.submit() create_delivery_note(pick_list_1.name) for dn in frappe.get_all( @@ -597,8 +591,7 @@ class TestPickList(FrappeTestCase): pl = create_pick_list(so.name) # pick half the qty for loc in pl.locations: - loc.stock_qty = loc.stock_qty /2 - loc.picked_qty = loc.stock_qty + loc.picked_qty = loc.stock_qty / 2 pl.save() pl.submit() @@ -618,7 +611,6 @@ class TestPickList(FrappeTestCase): pl.save() self.assertEqual(len(pl.locations), 2) for item in pl.locations: - item.picked_qty = item.stock_qty self.assertEqual(item.stock_qty, bundle_items[item.item_code] * 3) # check picking status on sales order @@ -644,8 +636,7 @@ class TestPickList(FrappeTestCase): pl = create_pick_list(so.name) for loc in pl.locations: - loc.stock_qty = loc.stock_qty / 2 - loc.picked_qty = loc.stock_qty + loc.picked_qty = loc.qty / 2 pl.save().submit() so.reload() @@ -658,8 +649,6 @@ class TestPickList(FrappeTestCase): self.assertEqual(so.per_delivered, 50) pl = create_pick_list(so.name) - for loc in pl.locations: - loc.picked_qty = loc.stock_qty pl.save().submit() so.reload() self.assertEqual(so.per_picked, 100)