Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: sider issues

Browse Source
This commit is contained in:
Devin Slauenwhite 2021-12-30 13:22:25 -05:00 committed by marination
parent b88d5d135e
commit 48da3b4482
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
erpnext/selling/doctype/quotation/quotation.py
View File

@ -51,7 +51,8 @@ class Quotation(SellingController):
frappe.throw(_("Valid till date cannot be before transaction date")) frappe.throw(_("Valid till date cannot be before transaction date"))
def validate_shopping_cart_items(self): def validate_shopping_cart_items(self):
if self.order_type != "Shopping Cart": return if self.order_type != "Shopping Cart":
return
for item in self.items: for item in self.items:
if not frappe.db.exists("Website Item", {"item_code": item.item_code}): if not frappe.db.exists("Website Item", {"item_code": item.item_code}):

2
erpnext/selling/doctype/quotation/test_quotation.py
View File

@ -131,8 +131,6 @@ class TestQuotation(FrappeTestCase):
self.assertRaises(frappe.ValidationError, make_sales_order, quotation.name) self.assertRaises(frappe.ValidationError, make_sales_order, quotation.name)
def test_shopping_cart_without_website_item(self): def test_shopping_cart_without_website_item(self):
from erpnext.selling.doctype.quotation.quotation import make_sales_order
if frappe.db.exists('Website Item', {'item_code': '_Test Item Home Desktop 100'}): if frappe.db.exists('Website Item', {'item_code': '_Test Item Home Desktop 100'}):
frappe.get_last_doc('Website Item', {'item_code': '_Test Item Home Desktop 100'}).delete() frappe.get_last_doc('Website Item', {'item_code': '_Test Item Home Desktop 100'}).delete()