Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #23828 from abhishekbalam/psoa_testcase_fix

Browse Source 
fix(PSOA): key error if no customers found
This commit is contained in:
Abhishek Balam 2020-11-05 00:21:24 +05:30 committed by GitHub
commit 48d9173a55
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.js
View File

@ -92,7 +92,7 @@ frappe.ui.form.on('Process Statement Of Accounts', {
frm.refresh_field('customers'); frm.refresh_field('customers');
} }
else{ else{
frappe.msgprint('No Customers found with selected options.'); frappe.throw('No Customers found with selected options.');
} }
} }
} }

6
erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.py
View File

@ -126,9 +126,11 @@ def get_customers_based_on_sales_person(sales_person):
sales_person_records = frappe._dict() sales_person_records = frappe._dict()
for d in records: for d in records:
sales_person_records.setdefault(d.parenttype, set()).add(d.parent) sales_person_records.setdefault(d.parenttype, set()).add(d.parent)
customers = frappe.get_list('Customer', fields=['name', 'email_id'], \ if sales_person_records.get('Customer'):
return frappe.get_list('Customer', fields=['name', 'email_id'], \
filters=[['name', 'in', list(sales_person_records['Customer'])]]) filters=[['name', 'in', list(sales_person_records['Customer'])]])
return customers else:
return []
def get_recipients_and_cc(customer, doc): def get_recipients_and_cc(customer, doc):
recipients = [] recipients = []