Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf: Single query to delete bins instead of N

Browse Source
This commit is contained in:
Ankush Menat 2022-03-19 20:05:19 +05:30 committed by Ankush Menat
parent 684d9d66d1
commit 4859574233
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
erpnext/stock/doctype/warehouse/warehouse.py
View File

@ -46,8 +46,6 @@ class Warehouse(NestedSet):
if d['actual_qty'] or d['reserved_qty'] or d['ordered_qty'] or \ if d['actual_qty'] or d['reserved_qty'] or d['ordered_qty'] or \
d['indented_qty'] or d['projected_qty'] or d['planned_qty']: d['indented_qty'] or d['projected_qty'] or d['planned_qty']:
throw(_("Warehouse {0} can not be deleted as quantity exists for Item {1}").format(self.name, d['item_code'])) throw(_("Warehouse {0} can not be deleted as quantity exists for Item {1}").format(self.name, d['item_code']))
else:
frappe.db.delete("Bin", filters={"name": d["name"]})
if self.check_if_sle_exists(): if self.check_if_sle_exists():
throw(_("Warehouse can not be deleted as stock ledger entry exists for this warehouse.")) throw(_("Warehouse can not be deleted as stock ledger entry exists for this warehouse."))
@ -55,6 +53,7 @@ class Warehouse(NestedSet):
if self.check_if_child_exists(): if self.check_if_child_exists():
throw(_("Child warehouse exists for this warehouse. You can not delete this warehouse.")) throw(_("Child warehouse exists for this warehouse. You can not delete this warehouse."))
frappe.db.delete("Bin", filters={"warehouse": self.name})
self.update_nsm_model() self.update_nsm_model()
self.unlink_from_items() self.unlink_from_items()