Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Consider discount_amount only when provided to calculate rate

Browse Source 
After selecting item_code in items table and not entering rate,
Clicking elsewhere will set rate to NaN.

All DocTypes on buying side have this bug.
This commit is contained in:
Aditya Hase 2019-06-18 19:11:17 +05:30
parent 226ff5a797
commit 48585c94ff
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/public/js/controllers/buying.js
View File

@ -144,7 +144,9 @@ erpnext.buying.BuyingController = erpnext.TransactionController.extend({
item.discount_amount = flt(item_rate) * flt(item.discount_percentage) / 100; item.discount_amount = flt(item_rate) * flt(item.discount_percentage) / 100;
} }
item.rate = flt((item.price_list_rate) - (item.discount_amount), precision('rate', item)); if (item.discount_amount) {
item.rate = flt((item.price_list_rate) - (item.discount_amount), precision('rate', item));
}
this.calculate_taxes_and_totals(); this.calculate_taxes_and_totals();
}, },