From 4741182b25f414bea1c3c60d0702c635b606f4aa Mon Sep 17 00:00:00 2001 From: makeen Date: Mon, 15 Feb 2016 10:44:11 +0100 Subject: [PATCH] [fix] add subscribers even though some emails are invalid --- erpnext/crm/doctype/newsletter_list/newsletter_list.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/erpnext/crm/doctype/newsletter_list/newsletter_list.py b/erpnext/crm/doctype/newsletter_list/newsletter_list.py index f84131b1f8..d56b5ad2a7 100644 --- a/erpnext/crm/doctype/newsletter_list/newsletter_list.py +++ b/erpnext/crm/doctype/newsletter_list/newsletter_list.py @@ -67,9 +67,9 @@ def add_subscribers(name, email_list): count = 0 for email in email_list: email = email.strip() - validate_email_add(email, True) + valid = validate_email_add(email, False) - if email: + if valid: if not frappe.db.get_value("Newsletter List Subscriber", {"newsletter_list": name, "email": email}): frappe.get_doc({ @@ -81,6 +81,8 @@ def add_subscribers(name, email_list): count += 1 else: pass + else: + frappe.msgprint(_("{0} is not a valid email id").format(email)) frappe.msgprint(_("{0} subscribers added").format(count))