From f509d13d2828af9f51023765a0ffc4abce140856 Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Tue, 12 Apr 2016 17:01:39 +0530 Subject: [PATCH 1/2] [fix] Get average selling rate based on group by --- erpnext/accounts/report/gross_profit/gross_profit.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/erpnext/accounts/report/gross_profit/gross_profit.py b/erpnext/accounts/report/gross_profit/gross_profit.py index ba87cf1c14..4ae0e6794d 100644 --- a/erpnext/accounts/report/gross_profit/gross_profit.py +++ b/erpnext/accounts/report/gross_profit/gross_profit.py @@ -145,11 +145,11 @@ class GrossProfitGenerator(object): self.data.append(row) if self.grouped: - self.collapse_group() + self.get_average_rate_based_on_group_by() else: self.grouped_data = [] - def collapse_group(self): + def get_average_rate_based_on_group_by(self): # sum buying / selling totals for group self.grouped_data = [] for key in self.grouped.keys(): @@ -166,6 +166,8 @@ class GrossProfitGenerator(object): if new_row.base_amount else 0 new_row.buying_rate = (new_row.buying_amount / new_row.qty) \ if new_row.qty else 0 + new_row.base_rate = (new_row.base_amount / new_row.qty) \ + if new_row.qty else 0 self.grouped_data.append(new_row) From 8a686ba9821f7aa7c08ac84eb2f9bd0aa4a8c510 Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Tue, 12 Apr 2016 17:02:15 +0530 Subject: [PATCH 2/2] [fix] Prevent from directly creating payment request --- .../accounts/doctype/payment_request/payment_request.json | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/erpnext/accounts/doctype/payment_request/payment_request.json b/erpnext/accounts/doctype/payment_request/payment_request.json index e916034d29..74a18fcf59 100644 --- a/erpnext/accounts/doctype/payment_request/payment_request.json +++ b/erpnext/accounts/doctype/payment_request/payment_request.json @@ -598,13 +598,13 @@ "hide_heading": 0, "hide_toolbar": 0, "idx": 0, - "in_create": 0, + "in_create": 1, "in_dialog": 0, "is_submittable": 1, "issingle": 0, "istable": 0, "max_attachments": 0, - "modified": "2016-02-24 16:49:46.832403", + "modified": "2016-04-12 15:26:22.756129", "modified_by": "Administrator", "module": "Accounts", "name": "Payment Request", @@ -675,5 +675,6 @@ "read_only": 0, "read_only_onload": 0, "sort_field": "modified", - "sort_order": "DESC" + "sort_order": "DESC", + "track_seen": 0 } \ No newline at end of file