From 4671038211d0cf0152f49126e43dbf5f54ef0b68 Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Wed, 6 Jul 2016 15:46:44 +0530 Subject: [PATCH] Item Name added in Stock Reconciliation --- .../bank_reconciliation.py | 4 +- .../stock_reconciliation.js | 2 + .../stock_reconciliation_item.json | 75 +++++++++++++++++-- 3 files changed, 72 insertions(+), 9 deletions(-) diff --git a/erpnext/accounts/doctype/bank_reconciliation/bank_reconciliation.py b/erpnext/accounts/doctype/bank_reconciliation/bank_reconciliation.py index b07c82d5a2..a56170d992 100644 --- a/erpnext/accounts/doctype/bank_reconciliation/bank_reconciliation.py +++ b/erpnext/accounts/doctype/bank_reconciliation/bank_reconciliation.py @@ -34,7 +34,7 @@ class BankReconciliation(Document): t2.parent = t1.name and t2.account = %s and t1.docstatus=1 and t1.posting_date >= %s and t1.posting_date <= %s and ifnull(t1.is_opening, 'No') = 'No' {0} - order by t1.posting_date DESC, t1.name DESC + order by t1.posting_date ASC, t1.name DESC """.format(condition), (self.bank_account, self.from_date, self.to_date), as_dict=1) payment_entries = frappe.db.sql(""" @@ -48,7 +48,7 @@ class BankReconciliation(Document): (paid_from=%s or paid_to=%s) and docstatus=1 and posting_date >= %s and posting_date <= %s {0} order by - posting_date DESC, name DESC + posting_date ASC, name DESC """.format(condition), (self.bank_account, self.bank_account, self.bank_account, self.from_date, self.to_date), as_dict=1) diff --git a/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js b/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js index 61e36e62ec..58b3549d1a 100644 --- a/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js +++ b/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js @@ -5,6 +5,8 @@ frappe.provide("erpnext.stock"); frappe.ui.form.on("Stock Reconciliation", { onload: function(frm) { + frm.add_fetch("item_code", "item_name", "item_name"); + // end of life frm.set_query("item_code", "items", function(doc, cdt, cdn) { return { diff --git a/erpnext/stock/doctype/stock_reconciliation_item/stock_reconciliation_item.json b/erpnext/stock/doctype/stock_reconciliation_item/stock_reconciliation_item.json index f9d8b3d81e..c32d07f10a 100644 --- a/erpnext/stock/doctype/stock_reconciliation_item/stock_reconciliation_item.json +++ b/erpnext/stock/doctype/stock_reconciliation_item/stock_reconciliation_item.json @@ -2,6 +2,7 @@ "allow_copy": 0, "allow_import": 0, "allow_rename": 0, + "beta": 0, "creation": "2015-02-17 01:06:05.072764", "custom": 0, "docstatus": 0, @@ -16,6 +17,7 @@ "fieldtype": "Link", "hidden": 0, "ignore_user_permissions": 0, + "ignore_xss_filter": 0, "in_filter": 0, "in_list_view": 1, "label": "Item Code", @@ -33,6 +35,31 @@ "set_only_once": 0, "unique": 0 }, + { + "allow_on_submit": 0, + "bold": 0, + "collapsible": 0, + "fieldname": "item_name", + "fieldtype": "Data", + "hidden": 0, + "ignore_user_permissions": 0, + "ignore_xss_filter": 0, + "in_filter": 0, + "in_list_view": 0, + "label": "Item Name", + "length": 0, + "no_copy": 1, + "permlevel": 0, + "precision": "", + "print_hide": 1, + "print_hide_if_no_value": 0, + "read_only": 1, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 + }, { "allow_on_submit": 0, "bold": 0, @@ -41,6 +68,7 @@ "fieldtype": "Link", "hidden": 0, "ignore_user_permissions": 0, + "ignore_xss_filter": 0, "in_filter": 0, "in_list_view": 1, "label": "Warehouse", @@ -62,10 +90,11 @@ "allow_on_submit": 0, "bold": 0, "collapsible": 0, - "fieldname": "section_break_3", - "fieldtype": "Section Break", + "fieldname": "column_break_6", + "fieldtype": "Column Break", "hidden": 0, "ignore_user_permissions": 0, + "ignore_xss_filter": 0, "in_filter": 0, "in_list_view": 0, "length": 0, @@ -90,6 +119,7 @@ "fieldtype": "Float", "hidden": 0, "ignore_user_permissions": 0, + "ignore_xss_filter": 0, "in_filter": 0, "in_list_view": 1, "label": "Quantity", @@ -115,6 +145,7 @@ "fieldtype": "Currency", "hidden": 0, "ignore_user_permissions": 0, + "ignore_xss_filter": 0, "in_filter": 0, "in_list_view": 1, "label": "Valuation Rate", @@ -135,10 +166,11 @@ "allow_on_submit": 0, "bold": 0, "collapsible": 0, - "fieldname": "column_break_6", - "fieldtype": "Column Break", + "fieldname": "section_break_3", + "fieldtype": "Section Break", "hidden": 0, "ignore_user_permissions": 0, + "ignore_xss_filter": 0, "in_filter": 0, "in_list_view": 0, "length": 0, @@ -163,6 +195,7 @@ "fieldtype": "Float", "hidden": 0, "ignore_user_permissions": 0, + "ignore_xss_filter": 0, "in_filter": 0, "in_list_view": 0, "label": "Current Qty", @@ -179,6 +212,30 @@ "set_only_once": 0, "unique": 0 }, + { + "allow_on_submit": 0, + "bold": 0, + "collapsible": 0, + "fieldname": "column_break_9", + "fieldtype": "Column Break", + "hidden": 0, + "ignore_user_permissions": 0, + "ignore_xss_filter": 0, + "in_filter": 0, + "in_list_view": 0, + "length": 0, + "no_copy": 0, + "permlevel": 0, + "precision": "", + "print_hide": 0, + "print_hide_if_no_value": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 + }, { "allow_on_submit": 0, "bold": 0, @@ -188,6 +245,7 @@ "fieldtype": "Read Only", "hidden": 0, "ignore_user_permissions": 0, + "ignore_xss_filter": 0, "in_filter": 0, "in_list_view": 0, "label": "Current Valuation Rate", @@ -208,6 +266,7 @@ "hide_heading": 0, "hide_toolbar": 0, "idx": 0, + "image_view": 0, "in_create": 0, "in_dialog": 0, "is_submittable": 0, @@ -215,15 +274,17 @@ "istable": 1, "max_attachments": 0, "menu_index": 0, - "modified": "2016-01-27 16:04:42.325454", + "modified": "2016-07-06 15:43:52.495428", "modified_by": "Administrator", "module": "Stock", "name": "Stock Reconciliation Item", "name_case": "", "owner": "Administrator", "permissions": [], + "quick_entry": 1, "read_only": 0, "read_only_onload": 0, "sort_field": "modified", - "sort_order": "DESC" -} + "sort_order": "DESC", + "track_seen": 0 +} \ No newline at end of file