Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Update payments directly in Loan Interest Accrual

Browse Source
This commit is contained in:
Deepesh Garg 2020-11-30 10:55:12 +05:30
parent 681c0e297c
commit 452cbcd6ea
1 changed files with 24 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
erpnext/patches/v13_0/update_old_loans.py
View File

@ -5,6 +5,7 @@ from frappe.utils import nowdate
from erpnext.accounts.doctype.account.test_account import create_account from erpnext.accounts.doctype.account.test_account import create_account
from erpnext.loan_management.doctype.process_loan_interest_accrual.process_loan_interest_accrual import process_loan_interest_accrual_for_term_loans from erpnext.loan_management.doctype.process_loan_interest_accrual.process_loan_interest_accrual import process_loan_interest_accrual_for_term_loans
from erpnext.loan_management.doctype.loan.loan import make_repayment_entry from erpnext.loan_management.doctype.loan.loan import make_repayment_entry
from erpnext.loan_management.doctype.loan_repayment.loan_repayment import get_accrued_interest_entries
from frappe.model.naming import make_autoname from frappe.model.naming import make_autoname
def execute(): def execute():
@ -100,25 +101,32 @@ def execute():
process_loan_interest_accrual_for_term_loans(posting_date=nowdate(), loan_type=loan_type, process_loan_interest_accrual_for_term_loans(posting_date=nowdate(), loan_type=loan_type,
loan=loan.name) loan=loan.name)
payments = frappe.db.sql(''' SELECT j.name, a.credit, a.credit_in_account_currency, j.posting_date accrued_entries = get_accrued_interest_entries(loan.name)
FROM `tabJournal Entry` j, `tabJournal Entry Account` a total_principal, total_interest = frappe.db.get_value('Repayment Schedule', fields=['sum(principal_amount) as total_principal',
WHERE a.parent = j.name and a.reference_type='Loan' and a.reference_name = %s 'sum(interest_amount) as total_interest'], filters={'is_paid': 1, 'parent': loan.name})
and a.account = %s and j.docstatus = 1
''', (loan.name, loan.loan_account), as_dict=1)
for payment in payments: for entry in accrued_entries:
if payment.credit_in_account_currency: interest_paid = 0
repayment_entry = make_repayment_entry(loan.name, loan.loan_applicant_type, loan.applicant, principal_paid = 0
loan_type, loan.company)
repayment_entry.amount_paid = payment.credit_in_account_currency if total_interest > entry.interest_amount:
repayment_entry.posting_date = payment.posting_date interest_paid = entry.interest_amount
repayment_entry.save() else:
repayment_entry.submit() interest_paid = total_interest
jv = frappe.get_doc('Journal Entry', payment.name) if total_principal > entry.payable_principal_amount:
jv.flags.ignore_links = True principal_paid = entry.payable_principal_amount
jv.cancel() else:
principal_paid = total_principal
frappe.db.sql(""" UPDATE `tabLoan Interest Accrual`
SET paid_principal_amount = `paid_principal_amount` + %s,
paid_interest_amount = `paid_interest_amount` + %s
WHERE name = %s""",
(principal_paid, interest_paid, entry.name))
total_principal -= principal_paid
total_interest -= interest_paid
def create_loan_type(loan, loan_type_name, penalty_account): def create_loan_type(loan, loan_type_name, penalty_account):
loan_type_doc = frappe.new_doc('Loan Type') loan_type_doc = frappe.new_doc('Loan Type')