Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: type-cast while saving an item (#32549)

Browse Source
This commit is contained in:
Rohan 2022-10-12 13:07:58 +05:30 committed by GitHub
parent 6ce3ce758c
commit 43037d893d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/stock/doctype/item/item.py
View File

@ -232,10 +232,10 @@ class Item(Document):
def clear_retain_sample(self): def clear_retain_sample(self):
if not self.has_batch_no: if not self.has_batch_no:
self.retain_sample = None self.retain_sample = False
if not self.retain_sample: if not self.retain_sample:
self.sample_quantity = None self.sample_quantity = 0
def add_default_uom_in_conversion_factor_table(self): def add_default_uom_in_conversion_factor_table(self):
if not self.is_new() and self.has_value_changed("stock_uom"): if not self.is_new() and self.has_value_changed("stock_uom"):

4
erpnext/stock/doctype/item/test_item.py
View File

@ -717,8 +717,8 @@ class TestItem(FrappeTestCase):
item.has_batch_no = None item.has_batch_no = None
item.save() item.save()
self.assertEqual(item.retain_sample, None) self.assertEqual(item.retain_sample, False)
self.assertEqual(item.sample_quantity, None) self.assertEqual(item.sample_quantity, 0)
item.delete() item.delete()
def consume_item_code_with_differet_stock_transactions( def consume_item_code_with_differet_stock_transactions(