Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: ignore empty customer/supplier in item query (#29610)

Browse Source 
* fix: dont try to filter by customer/supplier if None

* test: item query with emtpy supplier
This commit is contained in:
Ankush Menat 2022-02-03 13:02:13 +05:30 committed by GitHub
parent f696eddceb
commit 41a95e5624
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
erpnext/controllers/queries.py
View File

@ -249,6 +249,9 @@ def item_query(doctype, txt, searchfield, start, page_len, filters, as_dict=Fals
del filters['customer'] del filters['customer']
else: else:
del filters['supplier'] del filters['supplier']
else:
filters.pop('customer', None)
filters.pop('supplier', None)
description_cond = '' description_cond = ''

6
erpnext/controllers/tests/test_queries.py
View File

@ -56,6 +56,12 @@ class TestQueries(unittest.TestCase):
bundled_stock_items = query(txt="_test product bundle item 5", filters={"is_stock_item": 1}) bundled_stock_items = query(txt="_test product bundle item 5", filters={"is_stock_item": 1})
self.assertEqual(len(bundled_stock_items), 0) self.assertEqual(len(bundled_stock_items), 0)
# empty customer/supplier should be stripped of instead of failure
query(txt="", filters={"customer": None})
query(txt="", filters={"customer": ""})
query(txt="", filters={"supplier": None})
query(txt="", filters={"supplier": ""})
def test_bom_qury(self): def test_bom_qury(self):
query = add_default_params(queries.bom, "BOM") query = add_default_params(queries.bom, "BOM")