From c4e92c6416bba6953f23d5afeca08404046ec9ec Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Fri, 7 Feb 2014 15:22:50 +0530 Subject: [PATCH 1/2] Validate duplicate serial nos entry --- stock/doctype/serial_no/serial_no.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/stock/doctype/serial_no/serial_no.py b/stock/doctype/serial_no/serial_no.py index 57b3b460b1..ccfe3069d5 100644 --- a/stock/doctype/serial_no/serial_no.py +++ b/stock/doctype/serial_no/serial_no.py @@ -213,6 +213,10 @@ def validate_serial_no(sle, item_det): if len(serial_nos) and len(serial_nos) != abs(cint(sle.actual_qty)): webnotes.throw(_("Serial Nos do not match with qty") + \ (": %s (%s)" % (sle.item_code, sle.actual_qty)), SerialNoQtyError) + + # if len(serial_nos) != len(set(serial_nos)): + # webnotes.throw(_("Duplicate Serial No entered against item") + + # (": %s" % sle.item_code), SerialNoDuplicateError) for serial_no in serial_nos: if webnotes.conn.exists("Serial No", serial_no): From e1e5d675acf6b0e713a035916fa1f1f64c181f2f Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Fri, 7 Feb 2014 15:33:34 +0530 Subject: [PATCH 2/2] Validate duplicate serial nos entry --- stock/doctype/serial_no/serial_no.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/stock/doctype/serial_no/serial_no.py b/stock/doctype/serial_no/serial_no.py index ccfe3069d5..1cb4eee65f 100644 --- a/stock/doctype/serial_no/serial_no.py +++ b/stock/doctype/serial_no/serial_no.py @@ -214,9 +214,9 @@ def validate_serial_no(sle, item_det): webnotes.throw(_("Serial Nos do not match with qty") + \ (": %s (%s)" % (sle.item_code, sle.actual_qty)), SerialNoQtyError) - # if len(serial_nos) != len(set(serial_nos)): - # webnotes.throw(_("Duplicate Serial No entered against item") + - # (": %s" % sle.item_code), SerialNoDuplicateError) + if len(serial_nos) != len(set(serial_nos)): + webnotes.throw(_("Duplicate Serial No entered against item") + + (": %s" % sle.item_code), SerialNoDuplicateError) for serial_no in serial_nos: if webnotes.conn.exists("Serial No", serial_no):