Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: validate only for stock transactions

Browse Source
This commit is contained in:
Saqib Ansari 2020-10-10 21:56:50 +05:30
parent 776d8f72cf
commit 3d91d48b77
1 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
erpnext/utilities/transaction_base.py
View File

@ -32,7 +32,21 @@ class TransactionBase(StatusUpdater):
self.validate_future_posting() self.validate_future_posting()
self.validate_with_last_transaction_posting_time() self.validate_with_last_transaction_posting_time()
def is_stock_transaction(self):
if self.doctype not in ["Sales Invoice", "Purchase Invoice", "Stock Entry", "Stock Reconciliation",
"Delivery Note", "Purchase Receipt", "Fees"]:
return False
if self.doctype in ["Sales Invoice", "Purchase Invoice"]:
if not (self.get("update_stock") or self.get("is_pos")):
return False
return True
def validate_future_posting(self): def validate_future_posting(self):
if not self.is_stock_transaction():
return
if getattr(self, 'set_posting_time', None) and date_diff(self.posting_date, nowdate()) > 0: if getattr(self, 'set_posting_time', None) and date_diff(self.posting_date, nowdate()) > 0:
msg = _("Posting future transactions are not allowed due to Immutable Ledger") msg = _("Posting future transactions are not allowed due to Immutable Ledger")
frappe.throw(msg, title=_("Future Posting Not Allowed")) frappe.throw(msg, title=_("Future Posting Not Allowed"))
@ -168,12 +182,7 @@ class TransactionBase(StatusUpdater):
def validate_with_last_transaction_posting_time(self): def validate_with_last_transaction_posting_time(self):
if self.doctype not in ["Sales Invoice", "Purchase Invoice", "Stock Entry", "Stock Reconciliation", if not self.is_stock_transaction():
"Delivery Note", "Purchase Receipt", "Fees"]:
return
if self.doctype in ["Sales Invoice", "Purchase Invoice"]:
if not (self.get("update_stock") or self.get("is_pos")):
return return
for item in self.get('items'): for item in self.get('items'):