Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(Issue): reset response_by and resolution_by if SLA is removed (#25997)

Browse Source
This commit is contained in:
Ganga Manoj 2021-06-18 11:42:28 +05:30 committed by GitHub
parent b066fe9519
commit 3d8f82459b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/support/doctype/issue/issue.json
View File

@ -166,7 +166,7 @@
"options": "Service Level Agreement" "options": "Service Level Agreement"
}, },
{ {
"depends_on": "eval: doc.status != 'Replied';", "depends_on": "eval: doc.status != 'Replied' && doc.service_level_agreement;",
"fieldname": "response_by", "fieldname": "response_by",
"fieldtype": "Datetime", "fieldtype": "Datetime",
"label": "Response By", "label": "Response By",
@ -180,7 +180,7 @@
"read_only": 1 "read_only": 1
}, },
{ {
"depends_on": "eval: doc.status != 'Replied';", "depends_on": "eval: doc.status != 'Replied' && doc.service_level_agreement;",
"fieldname": "resolution_by", "fieldname": "resolution_by",
"fieldtype": "Datetime", "fieldtype": "Datetime",
"label": "Resolution By", "label": "Resolution By",
@ -410,7 +410,7 @@
"icon": "fa fa-ticket", "icon": "fa fa-ticket",
"idx": 7, "idx": 7,
"links": [], "links": [],
"modified": "2021-05-26 10:49:07.574769", "modified": "2021-06-10 03:22:27.098898",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Support", "module": "Support",
"name": "Issue", "name": "Issue",

12
erpnext/support/doctype/issue/issue.py
View File

@ -29,6 +29,9 @@ class Issue(Document):
self.update_status() self.update_status()
self.set_lead_contact(self.raised_by) self.set_lead_contact(self.raised_by)
if not self.service_level_agreement:
self.reset_sla_fields()
def on_update(self): def on_update(self):
# Add a communication in the issue timeline # Add a communication in the issue timeline
if self.flags.create_communication and self.via_customer_portal: if self.flags.create_communication and self.via_customer_portal:
@ -54,6 +57,13 @@ class Issue(Document):
self.company = frappe.db.get_value("Lead", self.lead, "company") or \ self.company = frappe.db.get_value("Lead", self.lead, "company") or \
frappe.db.get_default("Company") frappe.db.get_default("Company")
def reset_sla_fields(self):
self.agreement_status = ""
self.response_by = ""
self.resolution_by = ""
self.response_by_variance = 0
self.resolution_by_variance = 0
def update_status(self): def update_status(self):
status = frappe.db.get_value("Issue", self.name, "status") status = frappe.db.get_value("Issue", self.name, "status")
if self.status != "Open" and status == "Open" and not self.first_responded_on: if self.status != "Open" and status == "Open" and not self.first_responded_on:
@ -511,4 +521,4 @@ def get_time_in_timedelta(time):
Converts datetime.time(10, 36, 55, 961454) to datetime.timedelta(seconds=38215) Converts datetime.time(10, 36, 55, 961454) to datetime.timedelta(seconds=38215)
""" """
import datetime import datetime
return datetime.timedelta(hours=time.hour, minutes=time.minute, seconds=time.second) return datetime.timedelta(hours=time.hour, minutes=time.minute, seconds=time.second)