Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: max_qty validation condition

Browse Source 
(cherry picked from commit d198c488a4071d13d0891d87f790562febd44b3e)
This commit is contained in:
Sagar Sharma 2022-03-14 12:05:34 +05:30 committed by mergify-bot
parent fda60da07b
commit 3b86d6c73c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/manufacturing/doctype/work_order/work_order.py
View File

@ -647,12 +647,12 @@ class WorkOrder(Document):
if self.production_plan and self.production_plan_item: if self.production_plan and self.production_plan_item:
qty_dict = frappe.db.get_value("Production Plan Item", self.production_plan_item, ["planned_qty", "ordered_qty"], as_dict=1) qty_dict = frappe.db.get_value("Production Plan Item", self.production_plan_item, ["planned_qty", "ordered_qty"], as_dict=1)
allowance_qty =flt(frappe.db.get_single_value("Manufacturing Settings", allowance_qty = flt(frappe.db.get_single_value("Manufacturing Settings",
"overproduction_percentage_for_work_order"))/100 * qty_dict.get("planned_qty", 0) "overproduction_percentage_for_work_order"))/100 * qty_dict.get("planned_qty", 0)
max_qty = qty_dict.get("planned_qty", 0) + allowance_qty - qty_dict.get("ordered_qty", 0) max_qty = qty_dict.get("planned_qty", 0) + allowance_qty - qty_dict.get("ordered_qty", 0)
if max_qty < 1: if not max_qty > 0:
frappe.throw(_("Cannot produce more item for {0}") frappe.throw(_("Cannot produce more item for {0}")
.format(self.production_item), OverProductionError) .format(self.production_item), OverProductionError)
elif self.qty > max_qty: elif self.qty > max_qty: