From 70148a6748828f6edd34e20ba07449e4a7b6cccc Mon Sep 17 00:00:00 2001 From: vishal Date: Mon, 2 Dec 2019 17:37:46 +0530 Subject: [PATCH 1/4] feat: docstring added for auto cancel exempt doctypes --- erpnext/hooks.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/erpnext/hooks.py b/erpnext/hooks.py index c99ae7da5e..b301074e11 100644 --- a/erpnext/hooks.py +++ b/erpnext/hooks.py @@ -264,6 +264,11 @@ doc_events = { } } +# On cancel event Payment Entry will be exempted and all linked submittable doctype will get cancelled. +auto_cancel_exempt_doctypes = [ + "Payment Entry" +] + scheduler_events = { "all": [ "erpnext.projects.doctype.project.project.project_status_update_reminder" From eef05758b6a326d5b7ad6090760fe14ee0dec387 Mon Sep 17 00:00:00 2001 From: vishal Date: Thu, 5 Dec 2019 10:11:45 +0530 Subject: [PATCH 2/4] feat: Added docinfo for auto cancel exempt doctypes --- erpnext/hooks.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/erpnext/hooks.py b/erpnext/hooks.py index b301074e11..bf322b7b4f 100644 --- a/erpnext/hooks.py +++ b/erpnext/hooks.py @@ -265,6 +265,8 @@ doc_events = { } # On cancel event Payment Entry will be exempted and all linked submittable doctype will get cancelled. +# to maintain data integrity we exempted payment entry. it will un-link when sales invoice get cancelled. +# if payment entry not in auto cancel exempt doctype it will cancel payment entry. auto_cancel_exempt_doctypes = [ "Payment Entry" ] From 1dd289450f81b3502f69e13a7afe697c93340eeb Mon Sep 17 00:00:00 2001 From: vishal Date: Mon, 9 Dec 2019 14:13:27 +0530 Subject: [PATCH 3/4] fix: docstring for auto cancel --- erpnext/hooks.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/erpnext/hooks.py b/erpnext/hooks.py index bf322b7b4f..9c86906178 100644 --- a/erpnext/hooks.py +++ b/erpnext/hooks.py @@ -264,12 +264,9 @@ doc_events = { } } -# On cancel event Payment Entry will be exempted and all linked submittable doctype will get cancelled. -# to maintain data integrity we exempted payment entry. it will un-link when sales invoice get cancelled. -# if payment entry not in auto cancel exempt doctype it will cancel payment entry. -auto_cancel_exempt_doctypes = [ - "Payment Entry" -] +# To maintain data integrity, we exempt payments from being auto-cancelled when related documents +# are cancelled; payments will be unlinked instead whenever linked invoices are cancelled +auto_cancel_exempt_doctypes = ["Payment Entry"] scheduler_events = { "all": [ From dcef798be716b14ef932322dd9fc3bdc6bc947ad Mon Sep 17 00:00:00 2001 From: vishal Date: Mon, 13 Jan 2020 12:59:52 +0530 Subject: [PATCH 4/4] fix: minor changes --- erpnext/hooks.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/erpnext/hooks.py b/erpnext/hooks.py index 9c86906178..774c917f68 100644 --- a/erpnext/hooks.py +++ b/erpnext/hooks.py @@ -264,9 +264,12 @@ doc_events = { } } -# To maintain data integrity, we exempt payments from being auto-cancelled when related documents -# are cancelled; payments will be unlinked instead whenever linked invoices are cancelled -auto_cancel_exempt_doctypes = ["Payment Entry"] +# On cancel event Payment Entry will be exempted and all linked submittable doctype will get cancelled. +# to maintain data integrity we exempted payment entry. it will un-link when sales invoice get cancelled. +# if payment entry not in auto cancel exempted doctypes it will cancel payment entry. +auto_cancel_exempted_doctypes= [ + "Payment Entry" +] scheduler_events = { "all": [