From 38de9947885d5e6224ae13ef3c0b9d4b2ca8237d Mon Sep 17 00:00:00 2001 From: hiousi Date: Tue, 24 Apr 2018 08:40:45 +0200 Subject: [PATCH] do not copy template description to variant if not in allow fields (#13726) --- erpnext/controllers/item_variant.py | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/erpnext/controllers/item_variant.py b/erpnext/controllers/item_variant.py index 7749ac5f05..a54411903c 100644 --- a/erpnext/controllers/item_variant.py +++ b/erpnext/controllers/item_variant.py @@ -272,18 +272,19 @@ def copy_attributes_to_variant(item, variant): else: variant.set(field.fieldname, item.get(field.fieldname)) - variant.variant_of = item.name - variant.has_variants = 0 - if not variant.description: - variant.description = "" + if 'description' in allow_fields: + variant.variant_of = item.name + variant.has_variants = 0 + if not variant.description: + variant.description = "" - if item.variant_based_on=='Item Attribute': - if variant.attributes: - attributes_description = "" - for d in variant.attributes: - attributes_description += "
" + d.attribute + ": " + cstr(d.attribute_value) + "
" + if item.variant_based_on=='Item Attribute': + if variant.attributes: + attributes_description = "" + for d in variant.attributes: + attributes_description += "
" + d.attribute + ": " + cstr(d.attribute_value) + "
" - if attributes_description not in variant.description: + if attributes_description not in variant.description: variant.description += attributes_description def make_variant_item_code(template_item_code, template_item_name, variant):