Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: change make_gl_entries to work with new data structure

Browse Source
This commit is contained in:
barredterra 2021-09-23 20:14:45 +02:00 committed by marination
parent bc40f3f425
commit 3895c03ba9
1 changed files with 18 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
erpnext/accounts/doctype/dunning/dunning.py
View File

@ -5,11 +5,8 @@
import json import json
import frappe import frappe
from frappe.utils import cint, flt, getdate from frappe.utils import getdate
from erpnext.accounts.doctype.accounting_dimension.accounting_dimension import (
get_accounting_dimensions,
)
from erpnext.accounts.general_ledger import make_gl_entries, make_reverse_gl_entries from erpnext.accounts.general_ledger import make_gl_entries, make_reverse_gl_entries
from erpnext.controllers.accounts_controller import AccountsController from erpnext.controllers.accounts_controller import AccountsController
@ -47,57 +44,34 @@ class Dunning(AccountsController):
def make_gl_entries(self): def make_gl_entries(self):
if not self.dunning_amount: if not self.dunning_amount:
return return
gl_entries = []
invoice_fields = [
"project",
"cost_center",
"debit_to",
"party_account_currency",
"conversion_rate",
"cost_center",
]
inv = frappe.db.get_value("Sales Invoice", self.sales_invoice, invoice_fields, as_dict=1)
accounting_dimensions = get_accounting_dimensions() cost_center = self.cost_center or frappe.get_cached_value("Company", self.company, "cost_center")
invoice_fields.extend(accounting_dimensions)
dunning_in_company_currency = flt(self.dunning_amount * inv.conversion_rate) make_gl_entries(
default_cost_center = frappe.get_cached_value("Company", self.company, "cost_center") [
self.get_gl_dict({
gl_entries.append( "account": self.debit_to,
self.get_gl_dict(
{
"account": inv.debit_to,
"party_type": "Customer", "party_type": "Customer",
"party": self.customer, "party": self.customer,
"due_date": self.due_date, "due_date": self.due_date,
"against": self.income_account, "against": self.income_account,
"debit": dunning_in_company_currency, "debit": self.dunning_amount,
"debit_in_account_currency": self.dunning_amount, "debit_in_account_currency": self.dunning_amount,
"against_voucher": self.name, "against_voucher": self.name,
"against_voucher_type": "Dunning", "against_voucher_type": "Dunning",
"cost_center": inv.cost_center or default_cost_center, "cost_center": cost_center
"project": inv.project, }),
}, self.get_gl_dict({
inv.party_account_currency,
item=inv,
)
)
gl_entries.append(
self.get_gl_dict(
{
"account": self.income_account, "account": self.income_account,
"against": self.customer, "against": self.customer,
"credit": dunning_in_company_currency, "credit": self.dunning_amount,
"cost_center": inv.cost_center or default_cost_center, "cost_center": cost_center,
"credit_in_account_currency": self.dunning_amount, "credit_in_account_currency": self.dunning_amount
"project": inv.project, })
}, ],
item=inv, cancel=(self.docstatus == 2),
) update_outstanding="No",
) merge_entries=False
make_gl_entries(
gl_entries, cancel=(self.docstatus == 2), update_outstanding="No", merge_entries=False
) )