From e7044fa0f686287737902ca52d4b7354ebd9d0e6 Mon Sep 17 00:00:00 2001 From: Neil Trini Lasrado Date: Wed, 11 Mar 2015 17:07:58 +0530 Subject: [PATCH 1/2] validation added to check if multiple sales person have been given the same employee id --- erpnext/setup/doctype/sales_person/sales_person.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/erpnext/setup/doctype/sales_person/sales_person.py b/erpnext/setup/doctype/sales_person/sales_person.py index b4a8b7cca6..c2d36250c9 100644 --- a/erpnext/setup/doctype/sales_person/sales_person.py +++ b/erpnext/setup/doctype/sales_person/sales_person.py @@ -14,6 +14,7 @@ class SalesPerson(NestedSet): for d in self.get('targets') or []: if not flt(d.target_qty) and not flt(d.target_amount): frappe.throw(_("Either target qty or target amount is mandatory.")) + self.validate_employee_id() def on_update(self): super(SalesPerson, self).on_update() @@ -26,3 +27,7 @@ class SalesPerson(NestedSet): frappe.throw(_("User ID not set for Employee {0}").format(self.employee)) else: return frappe.db.get_value("User", user, "email") or user + + def validate_employee_id(self): + if frappe.db.exists({"doctype": "Sales Person","employee": self.employee}): + frappe.throw("Another sales person with the same empoyee id exists.") From c6dfb02e4afa04abb1d4b28742f30fe373c72af0 Mon Sep 17 00:00:00 2001 From: Neil Trini Lasrado Date: Thu, 12 Mar 2015 16:15:36 +0530 Subject: [PATCH 2/2] mend --- erpnext/setup/doctype/sales_person/sales_person.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/setup/doctype/sales_person/sales_person.py b/erpnext/setup/doctype/sales_person/sales_person.py index c2d36250c9..9098aaee27 100644 --- a/erpnext/setup/doctype/sales_person/sales_person.py +++ b/erpnext/setup/doctype/sales_person/sales_person.py @@ -30,4 +30,4 @@ class SalesPerson(NestedSet): def validate_employee_id(self): if frappe.db.exists({"doctype": "Sales Person","employee": self.employee}): - frappe.throw("Another sales person with the same empoyee id exists.") + frappe.throw("Another sales person with the same employee id exists.")