Shiloh/brotherton-erpnext
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #12435 from tundebabzy/packing-slip-msg

Browse Source 
Better validation message in Packing Slip
This commit is contained in:
tundebabzy 2018-01-11 00:32:26 +01:00 committed by GitHub
commit 3732033d9b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/stock/doctype/packing_slip/packing_slip.js
View File

@ -48,7 +48,7 @@ cur_frm.cscript.validate = function(doc, cdt, cdn) {
cur_frm.cscript.validate_case_nos = function(doc) { cur_frm.cscript.validate_case_nos = function(doc) {
doc = locals[doc.doctype][doc.name]; doc = locals[doc.doctype][doc.name];
if(cint(doc.from_case_no)==0) { if(cint(doc.from_case_no)==0) {
frappe.msgprint(__("Case No. cannot be 0")) frappe.msgprint(__("The 'From Package No.' field must neither be empty nor it's value less than 1."));
frappe.validated = false; frappe.validated = false;
} else if(!cint(doc.to_case_no)) { } else if(!cint(doc.to_case_no)) {
doc.to_case_no = doc.from_case_no; doc.to_case_no = doc.from_case_no;
@ -124,3 +124,5 @@ cur_frm.pformat.net_weight_pkg= function(doc){
cur_frm.pformat.gross_weight_pkg= function(doc){ cur_frm.pformat.gross_weight_pkg= function(doc){
return '<table style="width:100%">' + make_row('Gross Weight', doc.gross_weight_pkg) + '</table>' return '<table style="width:100%">' + make_row('Gross Weight', doc.gross_weight_pkg) + '</table>'
} }
// TODO: validate gross weight field