Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: show full item name in search widget (#28283)

Browse Source
This commit is contained in:
Ankush Menat 2021-11-09 11:55:33 +05:30 committed by GitHub
parent 0e8e7e21c3
commit 34f5283c17
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
erpnext/controllers/queries.py
View File

@ -210,12 +210,15 @@ def item_query(doctype, txt, searchfield, start, page_len, filters, as_dict=Fals
meta = frappe.get_meta("Item", cached=True) meta = frappe.get_meta("Item", cached=True)
searchfields = meta.get_search_fields() searchfields = meta.get_search_fields()
if "description" in searchfields: # these are handled separately
searchfields.remove("description") ignored_search_fields = ("item_name", "description")
for ignored_field in ignored_search_fields:
if ignored_field in searchfields:
searchfields.remove(ignored_field)
columns = '' columns = ''
extra_searchfields = [field for field in searchfields extra_searchfields = [field for field in searchfields
if not field in ["name", "item_group", "description"]] if not field in ["name", "item_group", "description", "item_name"]]
if extra_searchfields: if extra_searchfields:
columns = ", " + ", ".join(extra_searchfields) columns = ", " + ", ".join(extra_searchfields)
@ -252,10 +255,8 @@ def item_query(doctype, txt, searchfield, start, page_len, filters, as_dict=Fals
if frappe.db.count('Item', cache=True) < 50000: if frappe.db.count('Item', cache=True) < 50000:
# scan description only if items are less than 50000 # scan description only if items are less than 50000
description_cond = 'or tabItem.description LIKE %(txt)s' description_cond = 'or tabItem.description LIKE %(txt)s'
return frappe.db.sql("""select tabItem.name, return frappe.db.sql("""select
if(length(tabItem.item_name) > 40, tabItem.name, tabItem.item_name, tabItem.item_group,
concat(substr(tabItem.item_name, 1, 40), "..."), item_name) as item_name,
tabItem.item_group,
if(length(tabItem.description) > 40, \ if(length(tabItem.description) > 40, \
concat(substr(tabItem.description, 1, 40), "..."), description) as description concat(substr(tabItem.description, 1, 40), "..."), description) as description
{columns} {columns}