From ad11934d39f0dca68630f4231031f8965fc74cf6 Mon Sep 17 00:00:00 2001 From: Komal-Saraf0609 <81952590+Komal-Saraf0609@users.noreply.github.com> Date: Thu, 30 Mar 2023 08:03:55 +0530 Subject: [PATCH] fix: enabling lead even after "Opportunity" created against it (#34627) * fix: enabling lead even after "Opportunity" created against it * chore: Linting Issues --------- Co-authored-by: Komal Saraf Co-authored-by: Deepesh Garg --- erpnext/crm/doctype/opportunity/opportunity.py | 5 ----- erpnext/patches.txt | 1 + erpnext/patches/v15_0/enable_all_leads.py | 8 ++++++++ 3 files changed, 9 insertions(+), 5 deletions(-) create mode 100644 erpnext/patches/v15_0/enable_all_leads.py diff --git a/erpnext/crm/doctype/opportunity/opportunity.py b/erpnext/crm/doctype/opportunity/opportunity.py index f4b6e910ed..6a5fead0f8 100644 --- a/erpnext/crm/doctype/opportunity/opportunity.py +++ b/erpnext/crm/doctype/opportunity/opportunity.py @@ -33,7 +33,6 @@ class Opportunity(TransactionBase, CRMNote): def after_insert(self): if self.opportunity_from == "Lead": frappe.get_doc("Lead", self.party_name).set_status(update=True) - self.disable_lead() link_open_tasks(self.opportunity_from, self.party_name, self) link_open_events(self.opportunity_from, self.party_name, self) @@ -119,10 +118,6 @@ class Opportunity(TransactionBase, CRMNote): prospect.flags.ignore_mandatory = True prospect.save() - def disable_lead(self): - if self.opportunity_from == "Lead": - frappe.db.set_value("Lead", self.party_name, {"disabled": 1, "docstatus": 1}) - def make_new_lead_if_required(self): """Set lead against new opportunity""" if (not self.get("party_name")) and self.contact_email: diff --git a/erpnext/patches.txt b/erpnext/patches.txt index 0ef51a951d..3357b06fbb 100644 --- a/erpnext/patches.txt +++ b/erpnext/patches.txt @@ -330,3 +330,4 @@ erpnext.patches.v14_0.update_closing_balances # below migration patches should always run last erpnext.patches.v14_0.migrate_gl_to_payment_ledger execute:frappe.delete_doc_if_exists("Report", "Tax Detail") +erpnext.patches.v15_0.enable_all_leads diff --git a/erpnext/patches/v15_0/enable_all_leads.py b/erpnext/patches/v15_0/enable_all_leads.py new file mode 100644 index 0000000000..c1f2b47b5b --- /dev/null +++ b/erpnext/patches/v15_0/enable_all_leads.py @@ -0,0 +1,8 @@ +import frappe + + +def execute(): + lead = frappe.qb.DocType("Lead") + frappe.qb.update(lead).set(lead.disabled, 0).set(lead.docstatus, 0).where( + lead.disabled == 1 and lead.docstatus == 1 + ).run()