From 332a17ee8668aec357b0977784ceb074264a28df Mon Sep 17 00:00:00 2001 From: rohitwaghchaure Date: Thu, 1 Mar 2018 10:28:04 +0530 Subject: [PATCH] [Fix] Test case for serial no (#13136) --- erpnext/stock/doctype/serial_no/serial_no.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/stock/doctype/serial_no/serial_no.py b/erpnext/stock/doctype/serial_no/serial_no.py index 7194ec1c70..4c609df297 100644 --- a/erpnext/stock/doctype/serial_no/serial_no.py +++ b/erpnext/stock/doctype/serial_no/serial_no.py @@ -187,11 +187,11 @@ def process_serial_no(sle): update_serial_nos(sle, item_det) def validate_serial_no(sle, item_det): - if item_det.has_serial_no==0 and sle.is_cancelled == "No": + if item_det.has_serial_no==0: if sle.serial_no: frappe.throw(_("Item {0} is not setup for Serial Nos. Column must be blank").format(sle.item_code), SerialNoNotRequiredError) - else: + elif sle.is_cancelled == "No": if sle.serial_no: serial_nos = get_serial_nos(sle.serial_no) if cint(sle.actual_qty) != flt(sle.actual_qty):