From 32ebb1001e0eaff0110e5785f4c0fdbde6794c77 Mon Sep 17 00:00:00 2001 From: Anupam Date: Thu, 10 Jun 2021 19:32:00 +0530 Subject: [PATCH] fix: review chnages --- erpnext/payroll/doctype/payroll_entry/payroll_entry.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/erpnext/payroll/doctype/payroll_entry/payroll_entry.py b/erpnext/payroll/doctype/payroll_entry/payroll_entry.py index 67893448ba..7a70679db4 100644 --- a/erpnext/payroll/doctype/payroll_entry/payroll_entry.py +++ b/erpnext/payroll/doctype/payroll_entry/payroll_entry.py @@ -665,6 +665,8 @@ def get_employee_list(filters): emp_list = remove_payrolled_employees(emp_list, filters.start_date, filters.end_date) return emp_list + return [] + @frappe.whitelist() @frappe.validate_and_sanitize_search_inputs def employee_query(doctype, txt, searchfield, start, page_len, filters): @@ -673,7 +675,7 @@ def employee_query(doctype, txt, searchfield, start, page_len, filters): include_employees = [] emp_cond = '' if filters.start_date and filters.end_date: - employee_list = get_employee_list(filters) or [] + employee_list = get_employee_list(filters) emp = filters.get('employees') include_employees = [employee.employee for employee in employee_list if employee.employee not in emp] filters.pop('start_date')