Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: validate parent_expected_end_date in Task

Browse Source
This commit is contained in:
barredterra 2022-12-04 15:28:38 +01:00
parent 2c4eb371a6
commit 31db0e7c79
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/projects/doctype/task/task.py
View File

@ -9,6 +9,7 @@ from frappe import _, throw
from frappe.desk.form.assign_to import clear, close_all_assignments
from frappe.model.mapper import get_mapped_doc
from frappe.utils import add_days, cstr, date_diff, flt, get_link_to_form, getdate, today
from frappe.utils.data import format_date
from frappe.utils.nestedset import NestedSet
@ -43,15 +44,18 @@ class Task(NestedSet):
self.validate_parent_project_dates()
def validate_parent_expected_end_date(self):
if not self.parent_task:
if not self.parent_task or not self.exp_end_date:
return
parent_exp_end_date = frappe.db.get_value("Task", self.parent_task, "exp_end_date")
if parent_exp_end_date and getdate(self.get("exp_end_date")) > getdate(parent_exp_end_date):
if not parent_exp_end_date:
return
if getdate(self.exp_end_date) > getdate(parent_exp_end_date):
frappe.throw(
_(
"Expected End Date should be less than or equal to parent task's Expected End Date {0}."
).format(getdate(parent_exp_end_date)),
).format(format_date(parent_exp_end_date)),
frappe.exceptions.InvalidDates,
)