Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: query logic

Browse Source
This commit is contained in:
Saqib Ansari 2020-04-26 17:30:23 +05:30
parent 22d2970339
commit 2fea073539
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/patches/v12_0/fix_quotation_expired_status.py
View File

@ -1,5 +1,4 @@
import frappe import frappe
from frappe.utils import nowdate
def execute(): def execute():
# fixes status of quotations which have status 'Expired' despite having valid sales order created # fixes status of quotations which have status 'Expired' despite having valid sales order created
@ -16,7 +15,7 @@ def execute():
and qo.valid_till < so.transaction_date""" # check if SO was created after quotation expired and qo.valid_till < so.transaction_date""" # check if SO was created after quotation expired
frappe.db.sql( frappe.db.sql(
"""UPDATE `tabQuotation` qo SET qo.status = 'Expired' WHERE {cond} and not exists({invalid_so_against_quo})""" """UPDATE `tabQuotation` qo SET qo.status = 'Expired' WHERE {cond} and exists({invalid_so_against_quo})"""
.format(cond=cond, invalid_so_against_quo=invalid_so_against_quo) .format(cond=cond, invalid_so_against_quo=invalid_so_against_quo)
) )
@ -30,6 +29,6 @@ def execute():
and qo.valid_till >= so.transaction_date""" # check if SO was created before quotation expired and qo.valid_till >= so.transaction_date""" # check if SO was created before quotation expired
frappe.db.sql( frappe.db.sql(
"""UPDATE `tabQuotation` qo SET qo.status = 'Closed' WHERE {cond} and not exists({valid_so_against_quo})""" """UPDATE `tabQuotation` qo SET qo.status = 'Closed' WHERE {cond} and exists({valid_so_against_quo})"""
.format(cond=cond, valid_so_against_quo=valid_so_against_quo) .format(cond=cond, valid_so_against_quo=valid_so_against_quo)
) )